ol2: op: Version commit for op-v2023.33.01 #1285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@SeanChuangWiwynn - Can you rebase this and send me an IM and I'll get it merged rather quickly. The other version update got merged and now this one has a merge conflict. cc: @SaraLin-wiwynn |
Description - Version commit for op-v2023.33.01 Motivation - Version commit for op-v2023.33.01 Test Plan: 1. Build and test pass on OLP2.0 system Pass 2. Get version 1. Get all expansion card fw version. root@bmc-oob:~# fw-util slot1 --version 1ou_bic 1OU Bridge-IC Version: oby35-op-v2023.33.01 root@bmc-oob:~# fw-util slot1 --version 2ou_bic 2OU Bridge-IC Version: oby35-op-v2023.33.01 root@bmc-oob:~# fw-util slot1 --version 3ou_bic 3OU Bridge-IC Version: oby35-op-v2023.33.01 root@bmc-oob:~# fw-util slot1 --version 4ou_bic 4OU Bridge-IC Version: oby35-op-v2023.33.01
SeanChuangWiwynn
force-pushed
the
Sean/OLP_verion_commit_33.1
branch
from
3a501a6
to
d436b79
Compare
|
@SaraLin-wiwynn has updated the pull request. You must reimport the pull request before landing. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi Patrick,
I have fix the conflict.
Please help review again. Thanks!
Best Regards,
Sean
From: Patrick Williams ***@***.***>
Sent: Wednesday, August 16, 2023 4:42 AM
To: facebook/OpenBIC ***@***.***>
Cc: Sean Chuang/WYHQ/Wiwynn ***@***.***>; Mention ***@***.***>
Subject: Re: [facebook/OpenBIC] ol2: op: Version commit for op-v2023.33.01 (PR #1285)
Security Reminder: Please be aware that this email is sent by an external sender.
@SeanChuangWiwynn<https://github.com/SeanChuangWiwynn> - Can you rebase this and send me an IM and I'll get it merged rather quickly. The other version update got merged and now this one has a merge conflict.
cc: @SaraLin-wiwynn<https://github.com/SaraLin-wiwynn>
-
Reply to this email directly, view it on GitHub<#1285 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXLVLNS3SPB5JKFO3GLVYVDXVPNJRANCNFSM6AAAAAA3QQP37I>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
WIWYNN PROPRIETARY
This email (and any attachments) contains proprietary or confidential information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited. If you are not the intended recipient, please notify the sender and delete this email immediately.
|
|
This pull request has been merged in 48b8d80. |
SeanChuangWiwynn
added a commit
to Wiwynn/OpenBIC
that referenced
this pull request
Aug 18, 2023
Summary: # Description - Version commit for op-v2023.33.01 # Motivation - Version commit for op-v2023.33.01 Pull Request resolved: facebook#1285 Test Plan: 1. Build and test pass on OLP2.0 system Pass 2. Get version 1. Get all expansion card fw version. root@bmc-oob:~# fw-util slot1 --version 1ou_bic 1OU Bridge-IC Version: oby35-op-v2023.33.01 root@bmc-oob:~# fw-util slot1 --version 2ou_bic 2OU Bridge-IC Version: oby35-op-v2023.33.01 root@bmc-oob:~# fw-util slot1 --version 3ou_bic 3OU Bridge-IC Version: oby35-op-v2023.33.01 root@bmc-oob:~# fw-util slot1 --version 4ou_bic 4OU Bridge-IC Version: oby35-op-v2023.33.01 Reviewed By: williamspatrick Differential Revision: D48340702 fbshipit-source-id: d02866367d79adc49d60df20a478fc24b9197e8a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation
Test Plan
Build and test pass on OLP2.0 system Pass
Get version
Get all expansion card fw version. root@bmc-oob:
# fw-util slot1 --version 1ou_bic# fw-util slot1 --version 2ou_bic1OU Bridge-IC Version: oby35-op-v2023.33.01
root@bmc-oob:
2OU Bridge-IC Version: oby35-op-v2023.33.01
root@bmc-oob:
# fw-util slot1 --version 3ou_bic# fw-util slot1 --version 4ou_bic3OU Bridge-IC Version: oby35-op-v2023.33.01
root@bmc-oob:
4OU Bridge-IC Version: oby35-op-v2023.33.01