-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix running test262 #1412
Open
lavenzg
wants to merge
1
commit into
facebook:static_h
Choose a base branch
from
lavenzg:export-D57977650-to-static_h
base: static_h
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix running test262 #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
May 30, 2024
This pull request was exported from Phabricator. Differential Revision: D57977650 |
lavenzg
force-pushed
the
export-D57977650-to-static_h
branch
from
May 30, 2024 21:26
6726ea9
to
5c222b6
Compare
This pull request was exported from Phabricator. Differential Revision: D57977650 |
lavenzg
force-pushed
the
export-D57977650-to-static_h
branch
from
May 30, 2024 21:49
5c222b6
to
3519df0
Compare
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
May 30, 2024
Summary: Call the new test runner entry. Differential Revision: D57977650
This pull request was exported from Phabricator. Differential Revision: D57977650 |
Summary: Call the new test runner entry and fix the logic with "--test-intl", now it won't try to update the skiplist config without providing "--test-skiplist" together. Update the config w.r.t. to INTL as well. Differential Revision: D57977650
lavenzg
force-pushed
the
export-D57977650-to-static_h
branch
from
May 31, 2024 00:07
3519df0
to
912350f
Compare
This pull request was exported from Phabricator. Differential Revision: D57977650 |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 31, 2024
Summary: Pull Request resolved: #1412 Call the new test runner entry and fix the logic with "--test-intl", now it won't try to update the skiplist config without providing "--test-skiplist" together. Update the config w.r.t. to INTL as well. Reviewed By: avp Differential Revision: D57977650 fbshipit-source-id: cd5250184b35880440546138c3833dc462dc9c03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D57977650