Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the pointer of owning object in GCPointer::set() part II #1509

Open
wants to merge 16 commits into
base: static_h
Choose a base branch
from
Open

Pass the pointer of owning object in GCPointer::set() part II #1509

wants to merge 16 commits into from

Commits on Nov 21, 2024

  1. Define AlignedHeapSegmentBase 

    Differential Revision: D61675022
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    d3b94d4 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Add support of allocating different sizes of storage in StorageProvid… 

    …er (facebook#1504)

Summary:
Pull Request resolved: facebook#1504

Large segment needs to be backed by a large storage size.
StorageProvider currently always allocate fixed size of storage
determined by HERMESVM_LOG_HEAP_SEGMENT_SIZE.

This diffs adds support of allocating larger storage with below
changes:
1. `newStorage()` and `deleteStorage()` takes additional `sz` parameter.
2. For `MallocStorageProvider` and `VMAllocateStorageProvider`, simply
change the previous fixed storage size to passed in `sz`.
3. For `ContiguousVAStorageProvider`, use a BitVector to manage
allocations and deallocations. This can be improved later if we observe
fragmentations.

The support of enabling different sizes of heap segment will be added
later.

Differential Revision: D61676721
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    be94c84 View commit details
    Browse the repository at this point in the history

  2. Let SHSegmentInfo be explicit in CardTable 

    Differential Revision: D61747499
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    a4651d7 View commit details
    Browse the repository at this point in the history

  3. Store segment size in SHSegmentInfo 

    Differential Revision: D61807366
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    fb7cb7a View commit details
    Browse the repository at this point in the history

  4. Allow passing segment size to AlignedHeapSegmentBase 

    Differential Revision: D65828323
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    de60e39 View commit details
    Browse the repository at this point in the history

  5. Allow allocating CardStatus/Boundary array separately in CardTable 

    Differential Revision: D61747510
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    0f791c6 View commit details
    Browse the repository at this point in the history

  6. Store current cell in SlotAcceptor 

    Differential Revision: D64713261
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    e15594d View commit details
    Browse the repository at this point in the history

  7. Move rest CardTable functions to AlignedHeapSegmentBase 

    Differential Revision: D65638010
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    fc4f002 View commit details
    Browse the repository at this point in the history

  8. Add allowLargeAlloc to GCCell VTable 

    Differential Revision: D65638502
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    58464d0 View commit details
    Browse the repository at this point in the history

  9. Update constructorWriteBarrierRange 

    Differential Revision: D62171114
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    097db70 View commit details
    Browse the repository at this point in the history

  10. Add a findObject function to CardTable for assertions in writer barri… 

    …ers (facebook#1513)

Summary: Pull Request resolved: facebook#1513

Differential Revision: D62169632
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    d9b35eb View commit details
    Browse the repository at this point in the history

  11. Split of "[SH] Add write barrier variants that support large allocation" 

    Differential Revision: D65701671
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    e25d39f View commit details
    Browse the repository at this point in the history

  12. Add owning cell to parameters of GCHermesValueBase::set() 

    Differential Revision: D62196480
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    b8eee35 View commit details
    Browse the repository at this point in the history

  13. Add owning cell to ctor of GCHermesValueBase 

    Differential Revision: D62222238
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    16d8d29 View commit details
    Browse the repository at this point in the history

  14. Add pointer of owning object to GCPointer::set 

    Differential Revision: D62222257
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    5167da4 View commit details
    Browse the repository at this point in the history

  15. Pass the pointer of owning object in GCPointer::set() part II (facebo… 

    …ok#1509)

Summary: Pull Request resolved: facebook#1509

Differential Revision: D62227030
    @lavenzg @facebook-github-bot
    lavenzg authored and facebook-github-bot committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    c5040b7 View commit details
    Browse the repository at this point in the history