Pass the pointer of owning object in constructorWriteBarrierRange #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62171114 |
|
This pull request was exported from Phabricator. Differential Revision: D62171114 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Oct 21, 2024
…cebook#1511) Summary: Pull Request resolved: facebook#1511 Add a `GCCell` pointer parameter to `constructorWriteBarrierRange`, which represents the owning object address. It's used to get the correct card table for pointers live in large segment. Differential Revision: D62171114
lavenzg
force-pushed
the
export-D62171114-to-static_h
branch
from
68766c9
to
719f68c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62171114 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 8, 2024
…cebook#1511) Summary: Pull Request resolved: facebook#1511 Add a `GCCell` pointer parameter to `constructorWriteBarrierRange`, which represents the owning object address. It's used to get the correct card table for pointers live in large segment. Differential Revision: D62171114
lavenzg
force-pushed
the
export-D62171114-to-static_h
branch
from
719f68c
to
ad792f6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62171114 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Nov 14, 2024
…cebook#1511) Summary: Pull Request resolved: facebook#1511 Add a `GCCell` pointer parameter to `constructorWriteBarrierRange`, which represents the owning object address. It's used to get the correct card table for pointers live in large segment. Differential Revision: D62171114
lavenzg
force-pushed
the
export-D62171114-to-static_h
branch
from
ad792f6
to
0605a9d
Compare
Differential Revision: D61675022
…er (facebook#1504) Summary: Pull Request resolved: facebook#1504 Large segment needs to be backed by a large storage size. StorageProvider currently always allocate fixed size of storage determined by HERMESVM_LOG_HEAP_SEGMENT_SIZE. This diffs adds support of allocating larger storage with below changes: 1. `newStorage()` and `deleteStorage()` takes additional `sz` parameter. 2. For `MallocStorageProvider` and `VMAllocateStorageProvider`, simply change the previous fixed storage size to passed in `sz`. 3. For `ContiguousVAStorageProvider`, use a BitVector to manage allocations and deallocations. This can be improved later if we observe fragmentations. The support of enabling different sizes of heap segment will be added later. Differential Revision: D61676721
Differential Revision: D61747499
Differential Revision: D61807366
Differential Revision: D65828323
Differential Revision: D61747510
Differential Revision: D64713261
Differential Revision: D65638010
Differential Revision: D62158417
Differential Revision: D65638502
…cebook#1511) Summary: Pull Request resolved: facebook#1511 Add a `GCCell` pointer parameter to `constructorWriteBarrierRange`, which represents the owning object address. It's used to get the correct card table for pointers live in large segment. Differential Revision: D62171114
|
This pull request was exported from Phabricator. Differential Revision: D62171114 |
lavenzg
force-pushed
the
export-D62171114-to-static_h
branch
from
0605a9d
to
99c0510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a
GCCellpointer parameter toconstructorWriteBarrierRange,which represents the owning object address. It's used to get the
correct card table for pointers live in large segment.
Differential Revision: D62171114