igl | metal | Add debug name for SamplerState & DepthStencilState (#209)

Summary: Pull Request resolved: #209 Reviewed By: syeh1, tgoulart, KyleFung, mmaurer Differential Revision: D66250301 Pulled By: corporateshark fbshipit-source-id: 4350dc0c4f584620b332633f75a0261d0e50413e
facebook · Nov 20, 2024 · a4da488 · a4da488
1 parent f3f2141
commit a4da488
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/src/igl/DepthStencilState.h b/src/igl/DepthStencilState.h
@@ -118,6 +118,11 @@ struct StencilStateDesc {
  * the front and back face of polygons.
  */
 struct DepthStencilStateDesc {
+  /**
+   * @brief Identifier used for debugging
+   */
+  std::string debugName;
+
   /**
    * @brief The comparison operation to use for depth testing.
    */

diff --git a/src/igl/metal/Device.mm b/src/igl/metal/Device.mm
@@ -305,7 +305,7 @@
     const DepthStencilStateDesc& desc,
     Result* outResult) const {
   MTLDepthStencilDescriptor* metalDesc = [MTLDepthStencilDescriptor new];
-
+  metalDesc.label = [NSString stringWithUTF8String:desc.debugName.c_str()];
   metalDesc.depthCompareFunction = DepthStencilState::convertCompareFunction(desc.compareFunction);
   metalDesc.depthWriteEnabled = desc.isDepthWriteEnabled;
   metalDesc.frontFaceStencil = DepthStencilState::convertStencilDescriptor(desc.frontFaceStencil);

diff --git a/src/igl/metal/PlatformDevice.mm b/src/igl/metal/PlatformDevice.mm
@@ -33,6 +33,7 @@
 std::shared_ptr<SamplerState> PlatformDevice::createSamplerState(const SamplerStateDesc& desc,
                                                                  Result* outResult) const {
   MTLSamplerDescriptor* metalDesc = [MTLSamplerDescriptor new];
+  metalDesc.label = [NSString stringWithUTF8String:desc.debugName.c_str()];
   metalDesc.minFilter = SamplerState::convertMinMagFilter(desc.minFilter);
   metalDesc.magFilter = SamplerState::convertMinMagFilter(desc.magFilter);
   metalDesc.mipFilter = SamplerState::convertMipFilter(desc.mipFilter);