Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【igl nanovg part-1】shell | ios | add stencil buffer #214

Closed
wants to merge 2 commits into from
Closed

【igl nanovg part-1】shell | ios | add stencil buffer #214

wants to merge 2 commits into from

Conversation

vinsentli
Copy link
Contributor

This is a prerequisite pull request for igl nanovg(#213).

@vinsentli vinsentli changed the title shell | ios | add stencil buffer 【igl nanovg part-1】shell | ios | add stencil buffer Nov 26, 2024
corporateshark
corporateshark requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@corporateshark corporateshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A correct fix would be to add an optional parameter to override the texture format.

@vinsentli
Copy link
Contributor Author

A correct fix would be to add an optional parameter to override the texture format.

done

@facebook-github-bot
Copy link
Contributor

@corporateshark has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@corporateshark merged this pull request in 49d674c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corporateshark corporateshark Awaiting requested review from corporateshark

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinsentli @facebook-github-bot @corporateshark