Make screenshot taking helper public #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D48864515 |
Summary: Pull Request resolved: facebook#39 This is something that we would like to reuse for our own screenshot tests in an app that is using IGL. Differential Revision: D48864515 fbshipit-source-id: 306fdcd962ac2319cb24b2b83d9fd9a36f194891
|
This pull request was exported from Phabricator. Differential Revision: D48864515 |
rshest
force-pushed
the
export-D48864515
branch
from
8a9afec
to
f6ba05c
Compare
|
Already merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is something that we would like to reuse for our own screenshot tests in the ReactNative/Granite/IGL implementation (see the next diff in the stack).
The method was internal, this diffs makes it usable from outside.
Differential Revision: D48864515