fix: remove unneeded changes

facebook · Oct 2, 2024 · 2c83553 · 2c83553
1 parent 3f46435
commit 2c83553
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 13 deletions.
diff --git a/packages/dev-runtime/src/stylex-create.js b/packages/dev-runtime/src/stylex-create.js
@@ -124,6 +124,7 @@ function createWithFns<S: { ... }>(
     if (origKey.startsWith('var(') && origKey.endsWith(')')) {
       key = origKey.slice(4, -1);
     }
+
     if (typeof value === 'function') {
       const [staticObj, inlineStylesFn] = splitStaticObj(
         value as $FlowFixMe,

diff --git a/packages/eslint-plugin/src/stylex-valid-shorthands.js b/packages/eslint-plugin/src/stylex-valid-shorthands.js
@@ -129,7 +129,6 @@ const stylexValidShorthands = {
       if (typeof key === 'string' && legacyNameMapping[key] != null) {
         context.report({
           node: property,
-          // $FlowFixMe[invalid-computed-prop]
           message: `Use "${legacyNameMapping[key]}" instead of legacy formats like "${key}" to adhere to logical property naming.`,
           fix: (fixer) => {
             // $FlowFixMe - We've already checked that key is a string and in legacyNameMapping

diff --git a/packages/shared/src/index.js b/packages/shared/src/index.js
@@ -60,15 +60,12 @@ export const utils: {
 export const messages: typeof m = m;
 export const IncludedStyles: typeof _IncludedStyles = _IncludedStyles;
 export const firstThatWorks: typeof stylexFirstThatWorks = stylexFirstThatWorks;
-export const PSEUDO_CLASS_PRIORITIES: $ReadOnly<{
-  +[string]: ?number,
-  ...typeof _PSEUDO_CLASS_PRIORITIES,
-}> = _PSEUDO_CLASS_PRIORITIES;
-export const AT_RULE_PRIORITIES: $ReadOnly<{
-  +[string]: ?number,
-  ...typeof _AT_RULE_PRIORITIES,
-}> = _AT_RULE_PRIORITIES;
-export const PSEUDO_ELEMENT_PRIORITY: number = _PSEUDO_ELEMENT_PRIORITY;
+export const PSEUDO_CLASS_PRIORITIES: typeof _PSEUDO_CLASS_PRIORITIES =
+  _PSEUDO_CLASS_PRIORITIES;
+export const AT_RULE_PRIORITIES: typeof _AT_RULE_PRIORITIES =
+  _AT_RULE_PRIORITIES;
+export const PSEUDO_ELEMENT_PRIORITY: typeof _PSEUDO_ELEMENT_PRIORITY =
+  _PSEUDO_ELEMENT_PRIORITY;
 
 export type InjectableStyle = _InjectableStyle;
 export type CompiledNamespaces = _CompiledNamespaces;

diff --git a/packages/shared/src/preprocess-rules/index.js b/packages/shared/src/preprocess-rules/index.js
@@ -39,7 +39,6 @@ export default function flatMapExpandedShorthands(
   const expansion: (
     string | number | null,
   ) => $ReadOnlyArray<[string, TStyleValue]> =
-    // $FlowFixMe[invalid-computed-prop]
     expansions[options.styleResolution ?? 'application-order'][key];
   if (expansion) {
     if (Array.isArray(value)) {

diff --git a/packages/shared/src/stylex-define-vars.js b/packages/shared/src/stylex-define-vars.js
@@ -74,7 +74,6 @@ export default function styleXDefineVars<Vars: VarsConfig>(
   );
 
   const injectableStyles = constructCssVariablesString(
-    // $FlowFixMe[incompatible-call] - Can't use a class when a plain object is expected
     variablesMap,
     themeNameHash,
   );

diff --git a/packages/shared/src/utils/property-priorities.js b/packages/shared/src/utils/property-priorities.js
@@ -749,7 +749,6 @@ export default function getPriority(key: string): number {
         ? key.slice(0, key.indexOf('('))
         : key;
 
-    // $FlowFixMe[invalid-computed-prop]
     return PSEUDO_CLASS_PRIORITIES[prop] ?? 40;
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -749,7 +749,6 @@ export default function getPriority(key: string): number { @@
             ? key.slice(0, key.indexOf('('))
             : key;
-        // $FlowFixMe[invalid-computed-prop]
         return PSEUDO_CLASS_PRIORITIES[prop] ?? 40;
       }
@@ Expand Down @@