Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Next.js + CLI example #618

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: Next.js + CLI example #618

wants to merge 3 commits into from

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Jun 25, 2024

Added a Next.js example that uses the CLI for compilation.

NOTE: Because of some strange NPM issues, the Next build fails with some strange errors. The CLI is not the root cause and the previous Next example has fallen into this before.

So, for now, this PR is not intended to be merged. It's primarily a test to ensure that the CLI does work for a Next.js app.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 25, 2024
Copy link

compressed-size: runtime library

Size change: 0.00 kB
Total size: 2.52 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./packages/stylex/lib/stylex.js 1.04 (3.22) 0.00 (0.00) 0.0% (0.0%)
./packages/stylex/lib/StyleXSheet.js 1.48 (3.75) 0.00 (0.00) 0.0% (0.0%)

Base automatically changed from feat/cli-css-layers-option to main June 25, 2024 11:30
Copy link

compressed-size: e2e bundles

Size change: 0.00 kB
Total size: 1128.74 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./apps/rollup-example/.build/bundle.js 1005.32 (10185.35) 0.00 (0.00) 0.0% (0.0%)
./apps/rollup-example/.build/stylex.css 123.42 (774.34) 0.00 (0.00) 0.0% (0.0%)

Copy link

github-actions bot commented Nov 9, 2024

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

@stylexjs/[email protected] size:compare
./size-compare.js /tmp/tmp.Fky0mPnlBa /tmp/tmp.MYzGpQUK6I

Results Base Patch Ratio
stylex/lib/stylex.js
· compressed 729 729 1.00
· minified 2,541 2,541 1.00
stylex/lib/StyleXSheet.js
· compressed 1,266 1,266 1.00
· minified 3,776 3,776 1.00
rollup-example/.build/bundle.js
· compressed 563,025 563,025 1.00
· minified 10,185,368 10,185,368 1.00
rollup-example/.build/stylex.css
· compressed 99,154 99,154 1.00
· minified 745,649 745,649 1.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants