Skip to content

Commit

Permalink
Allow monotonic rejection GP to initialize its inducing point allocat…
Browse files Browse the repository at this point in the history
…or from config. (#485)

Summary:
Pull Request resolved: #485

Monotonic rejection GP used to completely ignore any inducing point config, now it follows other models.

Differential Revision: D67225873
  • Loading branch information
JasonKChow authored and facebook-github-bot committed Dec 14, 2024
1 parent 9b3a0d0 commit e80bffa
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions aepsych/models/monotonic_rejection_gp.py
Original file line number Diff line number Diff line change
Expand Up @@ -355,15 +355,6 @@ def from_config(cls, config: Config) -> MonotonicRejectionGP:
ub = config.gettensor(classname, "ub")
dim = config.getint(classname, "dim", fallback=None)

inducing_point_method_class = config.getobj(
classname, "inducing_point_method", fallback=AutoAllocator
)
# Check if allocator class has a `from_config` method
if hasattr(inducing_point_method_class, "from_config"):
inducing_point_method = inducing_point_method_class.from_config(config)
else:
inducing_point_method = inducing_point_method_class()

mean_covar_factory = config.getobj(
classname, "mean_covar_factory", fallback=monotonic_mean_covar_factory
)
Expand All @@ -381,7 +372,6 @@ def from_config(cls, config: Config) -> MonotonicRejectionGP:
lb=lb,
ub=ub,
dim=dim,
inducing_point_method=inducing_point_method,
num_induc=num_induc,
num_samples=num_samples,
num_rejection_samples=num_rejection_samples,
Expand Down

0 comments on commit e80bffa

Please sign in to comment.