Fix GenerationStrategy and GenerataionNode todos #330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52898268 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 22, 2024
Summary: X-link: facebookresearch/aepsych#330 In this diff we update the Ax GenerationStrategy code to remove all todos related to aepsych, and use the standard GS code flow for aepsych usecases. This required some minimal updates to the aepsych criterion and one of the storage tests. In following diffs we will: - revisit storage - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Differential Revision: D52898268 fbshipit-source-id: 16d5c829a2187402dc0d18b1e22b88d2da5b4f3e
mgarrard
force-pushed
the
export-D52898268
branch
from
09e7a5f to
a619bc0
Compare
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 24, 2024
Summary: X-link: facebook/Ax#2142 In this diff we update the Ax GenerationStrategy code to remove all todos related to aepsych, and use the standard GS code flow for aepsych usecases. This required some minimal updates to the aepsych criterion and one of the storage tests. In following diffs we will: - revisit storage - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52898268
|
This pull request was exported from Phabricator. Differential Revision: D52898268 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 24, 2024
Summary: Pull Request resolved: facebook#2142 X-link: facebookresearch/aepsych#330 In this diff we update the Ax GenerationStrategy code to remove all todos related to aepsych, and use the standard GS code flow for aepsych usecases. This required some minimal updates to the aepsych criterion and one of the storage tests. In following diffs we will: - revisit storage - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52898268 fbshipit-source-id: 6dcf3d62641cbf652c80006cca39cff1fb4bb39a
mgarrard
force-pushed
the
export-D52898268
branch
from
a619bc0 to
e44d213
Compare
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 26, 2024
Summary: X-link: facebook/Ax#2142 In this diff we update the Ax GenerationStrategy code to remove all todos related to aepsych, and use the standard GS code flow for aepsych usecases. This required some minimal updates to the aepsych criterion and one of the storage tests. In following diffs we will: - revisit storage - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52898268
|
This pull request was exported from Phabricator. Differential Revision: D52898268 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 26, 2024
Summary: Pull Request resolved: facebook#2142 X-link: facebookresearch/aepsych#330 In this diff we update the Ax GenerationStrategy code to remove all todos related to aepsych, and use the standard GS code flow for aepsych usecases. This required some minimal updates to the aepsych criterion and one of the storage tests. In following diffs we will: - revisit storage - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52898268 fbshipit-source-id: 519739f596a4e497e6805c99a1757a412d6c2a1a
mgarrard
force-pushed
the
export-D52898268
branch
from
e44d213 to
f24ae62
Compare
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 29, 2024
Summary: X-link: facebook/Ax#2142 In this diff we update the Ax GenerationStrategy code to remove all todos related to aepsych, and use the standard GS code flow for aepsych usecases. This required some minimal updates to the aepsych criterion and one of the storage tests. In following diffs we will: - revisit storage - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52898268
|
This pull request was exported from Phabricator. Differential Revision: D52898268 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 29, 2024
Summary: Pull Request resolved: facebook#2142 X-link: facebookresearch/aepsych#330 In this diff we update the Ax GenerationStrategy code to remove all todos related to aepsych, and use the standard GS code flow for aepsych usecases. This required some minimal updates to the aepsych criterion and one of the storage tests. In following diffs we will: - revisit storage - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52898268 fbshipit-source-id: 843ba6a41f3a81a258f305169834062b8ec7fad0
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 30, 2024
Summary: X-link: facebook/Ax#2142 In this diff we update the Ax GenerationStrategy code to remove all todos related to aepsych, and use the standard GS code flow for aepsych usecases. This required some minimal updates to the aepsych criterion and one of the storage tests. In following diffs we will: - revisit storage - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52898268
mgarrard
force-pushed
the
export-D52898268
branch
from
f24ae62 to
ed6c580
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 30, 2024
Summary: X-link: facebookresearch/aepsych#330 In this diff we update the Ax GenerationStrategy code to remove all todos related to aepsych, and use the standard GS code flow for aepsych usecases. This required some minimal updates to the aepsych criterion and one of the storage tests. In following diffs we will: - revisit storage - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52898268
|
This pull request was exported from Phabricator. Differential Revision: D52898268 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 30, 2024
Summary: X-link: facebookresearch/aepsych#330 In this diff we update the Ax GenerationStrategy code to remove all todos related to aepsych, and use the standard GS code flow for aepsych usecases. This required some minimal updates to the aepsych criterion and one of the storage tests. In following diffs we will: - revisit storage - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52898268
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 30, 2024
Summary: X-link: facebook/Ax#2142 In this diff we update the Ax GenerationStrategy code to remove all todos related to aepsych, and use the standard GS code flow for aepsych usecases. This required some minimal updates to the aepsych criterion and one of the storage tests. In following diffs we will: - revisit storage - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52898268
mgarrard
force-pushed
the
export-D52898268
branch
from
ed6c580 to
57e86da
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 30, 2024
Summary: X-link: facebookresearch/aepsych#330 In this diff we update the Ax GenerationStrategy code to remove all todos related to aepsych, and use the standard GS code flow for aepsych usecases. This required some minimal updates to the aepsych criterion and one of the storage tests. In following diffs we will: - revisit storage - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52898268
|
This pull request was exported from Phabricator. Differential Revision: D52898268 |
Summary: X-link: facebook/Ax#2142 In this diff we update the Ax GenerationStrategy code to remove all todos related to aepsych, and use the standard GS code flow for aepsych usecases. This required some minimal updates to the aepsych criterion and one of the storage tests. In following diffs we will: - revisit storage - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52898268
mgarrard
force-pushed
the
export-D52898268
branch
from
57e86da to
9959333
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 31, 2024
Summary: X-link: facebookresearch/aepsych#330 In this diff we update the Ax GenerationStrategy code to remove all todos related to aepsych, and use the standard GS code flow for aepsych usecases. This required some minimal updates to the aepsych criterion and one of the storage tests. In following diffs we will: - revisit storage - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52898268
|
This pull request was exported from Phabricator. Differential Revision: D52898268 |
|
This pull request has been merged in dcda999. |
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Jan 31, 2024
Summary: Pull Request resolved: #2142 X-link: facebookresearch/aepsych#330 In this diff we update the Ax GenerationStrategy code to remove all todos related to aepsych, and use the standard GS code flow for aepsych usecases. This required some minimal updates to the aepsych criterion and one of the storage tests. In following diffs we will: - revisit storage - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52898268 fbshipit-source-id: 4cc98b100c26aed052322f13ae103455733e1606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In this diff we update the Ax GenerationStrategy code to remove all todos related to aepsych, and use the standard GS code flow for aepsych usecases. This required some minimal updates to the aepsych criterion and one of the storage tests.
In following diffs we will:
Differential Revision: D52898268