update db master table spec and corresponding helper functions #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66526187 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 27, 2024
…ookresearch#465) Summary: Update db master table spec such that experiment ID and participant is not unique. Functions that used experiment_id as a key have been swapped to use the master table's master key (unique_id). Functions appeared to expect that it's possible to get multiple entries back from a single experiment ID existed but didn't make sense since it was unique, this means nothing really needs to be changed. Replay functions used to leverage the experiment_id, here it is assumed to be unique, which it was. Now replay functions use the master table's unique_id to pick which experiment to replay, which conveniently also means it's a lot easier to just try integers starting from 0 (instead of finding a uuid). Metadata reading has been changed to correctly get all the information from the config to match the master table spec. These are technically breaking changes that may affect old scripts but it's not clear what db utility functions may be used in weird scripts trying to use experiment_ids to identify experiments. Still old dbs should all work and be compatible. Differential Revision: D66526187
JasonKChow
force-pushed
the
export-D66526187
branch
from
2c0e4a8 to
15f2ea6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66526187 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 27, 2024
…ookresearch#465) Summary: Update db master table spec such that experiment ID and participant is not unique. Functions that used experiment_id as a key have been swapped to use the master table's master key (unique_id). Functions appeared to expect that it's possible to get multiple entries back from a single experiment ID existed but didn't make sense since it was unique, this means nothing really needs to be changed. Replay functions used to leverage the experiment_id, here it is assumed to be unique, which it was. Now replay functions use the master table's unique_id to pick which experiment to replay, which conveniently also means it's a lot easier to just try integers starting from 0 (instead of finding a uuid). Metadata reading has been changed to correctly get all the information from the config to match the master table spec. These are technically breaking changes that may affect old scripts but it's not clear what db utility functions may be used in weird scripts trying to use experiment_ids to identify experiments. Still old dbs should all work and be compatible. Differential Revision: D66526187
JasonKChow
force-pushed
the
export-D66526187
branch
from
15f2ea6 to
acedaa7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66526187 |
JasonKChow
force-pushed
the
export-D66526187
branch
from
acedaa7 to
07e0daf
Compare
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Dec 16, 2024
…ookresearch#465) Summary: Update db master table spec such that experiment ID and participant is not unique. Functions that used experiment_id as a key have been swapped to use the master table's master key (unique_id). Functions appeared to expect that it's possible to get multiple entries back from a single experiment ID existed but didn't make sense since it was unique, this means nothing really needs to be changed. Replay functions used to leverage the experiment_id, here it is assumed to be unique, which it was. Now replay functions use the master table's unique_id to pick which experiment to replay, which conveniently also means it's a lot easier to just try integers starting from 0 (instead of finding a uuid). Metadata reading has been changed to correctly get all the information from the config to match the master table spec. These are technically breaking changes that may affect old scripts but it's not clear what db utility functions may be used in weird scripts trying to use experiment_ids to identify experiments. Still old dbs should all work and be compatible. Reviewed By: crasanders Differential Revision: D66526187
|
This pull request was exported from Phabricator. Differential Revision: D66526187 |
…ookresearch#465) Summary: Update db master table spec such that experiment ID and participant is not unique. Functions that used experiment_id as a key have been swapped to use the master table's master key (unique_id). Functions appeared to expect that it's possible to get multiple entries back from a single experiment ID existed but didn't make sense since it was unique, this means nothing really needs to be changed. Replay functions used to leverage the experiment_id, here it is assumed to be unique, which it was. Now replay functions use the master table's unique_id to pick which experiment to replay, which conveniently also means it's a lot easier to just try integers starting from 0 (instead of finding a uuid). Metadata reading has been changed to correctly get all the information from the config to match the master table spec. These are technically breaking changes that may affect old scripts but it's not clear what db utility functions may be used in weird scripts trying to use experiment_ids to identify experiments. Still old dbs should all work and be compatible. Reviewed By: crasanders Differential Revision: D66526187
JasonKChow
force-pushed
the
export-D66526187
branch
from
07e0daf to
629a94e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66526187 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Update db master table spec such that experiment ID and participant is not unique.
Functions that used experiment_id as a key have been swapped to use the master table's master key (unique_id). Functions appeared to expect that it's possible to get multiple entries back from a single experiment ID existed but didn't make sense since it was unique, this means nothing really needs to be changed.
Replay functions used to leverage the experiment_id, here it is assumed to be unique, which it was. Now replay functions use the master table's unique_id to pick which experiment to replay, which conveniently also means it's a lot easier to just try integers starting from 0 (instead of finding a uuid).
Metadata reading has been changed to correctly get all the information from the config to match the master table spec.
These are technically breaking changes that may affect old scripts but it's not clear what db utility functions may be used in weird scripts trying to use experiment_ids to identify experiments. Still old dbs should all work and be compatible.
Differential Revision: D66526187