convert circleci jobs to github actions #2900
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request converts the CircleCI workflows to GitHub actions workflows.
Notes
I chose the use the
microsoftversion of openjdk. See supported distributions for other options.Ubuntu 18.04 reached EOL May 2023. I have removed this job that tests on this OS version from the workflow.
It may be desireable to set
fail-fast: truein order to save $ on runners when jobs fail. I set this to true in order to see the results of all jobs.There is currently a defect in the
conda-incubator/setup-minicondaaction, I believe. TheCONDAenvironment variable is not set in the environment in all conditions. I have created an issue in the repo for this. My PR here solves the issue and is awaiting approval and merge. Once that is merged, change the.github/actions/setup-miniconda/action.ymlfile to use the official version of the action rather than my fork/branch.Errors
I did my best to make all the jobs work, but lacking knowledge specific to this project makes it nearly impossible for me to get everything working. Someone with better knowledge of this project will need to address the errors.
The
test_macos,test_linux,test_win, andtest_plugin_winjobs fail with an error. The best way to view the errors is by viewing the latest workflow run in my fork. Here is the latest workflow run in my fork.https://fburl.com/workplace/f6mz6tmw
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tested in fork.