-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: fetch app docs_url #24
Open
chipytux
wants to merge
14
commits into
fastapi:main
Choose a base branch
from
chipytux:feat/get_app_docs_url
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipytux
force-pushed
the
feat/get_app_docs_url
branch
from
May 13, 2024 22:43
becbe1e
to
dfec882
Compare
pedroimpulcetto
approved these changes
May 14, 2024
chipytux
force-pushed
the
feat/get_app_docs_url
branch
from
May 15, 2024 17:29
dfec882
to
fb3ee8e
Compare
Do you think this is a good approach @tiangolo ? 🙏🏻 |
pedroimpulcetto
approved these changes
May 26, 2024
@tiangolo I do not have permission to configure a label for the PR. https://github.com/fastapi/fastapi-cli/actions/runs/10408815023/job/28827030912?pr=24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Title: Fetch docs_url dynamically from FastAPI app
Description:
This pull request introduces a change to the
fastapi-cli
library that fetches thedocs_url
value dynamically from the FastAPI application instead of using a hardcoded value.Implementation Details:
The change involves modifying the
_run
function to fetch thedocs_url
value from the FastAPI application using theapp.openapi_url
attribute. This ensures that the library always uses the URL specified by the application itself.Testing:
The updated function has been thoroughly tested to ensure it correctly retrieves the
docs_url
value from the FastAPI application and show the appropriate URL.