Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade glob to v10 #406

Merged
merged 24 commits into from
Feb 1, 2024
Merged

Upgrade glob to v10 #406

merged 24 commits into from
Feb 1, 2024

Conversation

gurgunday
Copy link
Member

@gurgunday gurgunday commented Sep 6, 2023 •
edited
Loading

What changed: glob is stricter in its syntax so we have to escape characters more consistently

Closes: #402

Checklist

@gurgunday gurgunday marked this pull request as draft September 6, 2023 20:59
@gurgunday
Copy link
Member Author

Damn it actually worked 🤣

This should merge after #405

@gurgunday
Copy link
Member Author

gurgunday commented Sep 6, 2023 •
edited
Loading

Not sure about the license check that failed, one package seems to be using the BlueOak-1.0.0 license

@Uzlopak?

@gurgunday gurgunday added the dependencies Pull requests that update a dependency file label Sep 6, 2023
@Eomm
Copy link
Member

Eomm commented Sep 7, 2023

We may add it to the workflow:

isaacs/jackspeak#7

@gurgunday gurgunday marked this pull request as ready for review September 7, 2023 09:41
@gurgunday
Copy link
Member Author

We may add it to the workflow:

isaacs/jackspeak#7

@Eomm how can we do that?

@Uzlopak
Copy link
Contributor

Uzlopak commented Sep 7, 2023

Seems to be a hornet nest :(

https://writing.kemitchell.com/2019/05/05/Rely-on-OSI.html
angular/angular-cli#25387

@gurgunday
Copy link
Member Author

Looks like a cool license 🤠

mcollina
mcollina requested changes Sep 7, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one thing I'll put a temporary -1 on. I would need to check with the OpenJS Lawyers about this.

According to the OpenJS IP policy we cannot use BlueOak-1.0.0 https://openjsf.org/wp-content/uploads/sites/84/2019/10/OpenJS-Foundation-IP-Policy-2019-10-22.pdf.

@gurgunday
Copy link
Member Author

Oh, I didn't know that, no problem!

@gurgunday gurgunday mentioned this pull request Sep 7, 2023
Open
2 tasks
@jsumners
Copy link
Member

jsumners commented Sep 7, 2023

This is one thing I'll put a temporary -1 on. I would need to check with the OpenJS Lawyers about this.

According to the OpenJS IP policy we cannot use BlueOak-1.0.0 openjsf.org/wp-content/uploads/sites/84/2019/10/OpenJS-Foundation-IP-Policy-2019-10-22.pdf.

Wait, what? Why isn't BlueOak acceptable?

@mcollina
Copy link
Member

mcollina commented Sep 7, 2023

It's not OSI approved (by design). Trying to get a new OSS license through a major company legal department is very hard and that rule account for that. Note that we have the license checker since before we went into openjs exactly for this reason.

@mcollina
Copy link
Member

mcollina commented Sep 7, 2023

We had some adoption issue due to light-my-request BSD license (as funny as it sounds).

@jsumners jsumners mentioned this pull request Sep 16, 2023
Open
32 tasks
@gurgunday gurgunday mentioned this pull request Oct 2, 2023
Closed
@gurgunday
Copy link
Member Author

@mcollina is BSD-2-Clause-Patent acceptable in your opinion?

@Uzlopak
Copy link
Contributor

Uzlopak commented Oct 18, 2023

@gurgunday

https://github.com/fastify/workflows/blob/704b2c8d932efd159e3f28f64a535fe4bf423d92/.github/workflows/plugins-ci.yml#L66

@gurgunday
Copy link
Member Author

gurgunday commented Oct 18, 2023 •
edited
Loading

I know about the workflow, I'm just asking if, according to OpenJS Foundation policy, BSD-2-Clause-Patent could be considered as BSD-2-Clause

I'd say no, but just wanted to make sure, to maybe switch some personal packages to it if that's not the case

@mcollina
Copy link
Member

what library is using that license?

@gurgunday
Copy link
Member Author

None that I know of

I asked because I was considering creating a faster glob implementation that is as correct as node-glob and wanted to make a more informed decision on the License

@gurgunday
Copy link
Member Author

This can merge now

@Uzlopak
Copy link
Contributor

Uzlopak commented Jan 29, 2024 •
edited
Loading

@gurgunday Can you please add blue oak to the workflows?

@gurgunday gurgunday changed the base branch from master to next February 1, 2024 13:52
@gurgunday gurgunday changed the base branch from next to master February 1, 2024 14:51
@gurgunday gurgunday requested review from a team and mcollina February 1, 2024 14:53
mcollina
mcollina approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 9e56e07 into fastify:master Feb 1, 2024
19 checks passed
@gurgunday gurgunday deleted the globb branch February 1, 2024 15:15
ddadaal referenced this pull request in PKUHPC/OpenSCOW Feb 18, 2024
@renovate
fix(deps): update dependency @fastify/static to v7 (#1115)
7c9853c 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/static](https://togithub.com/fastify/fastify-static) |
[`6.12.0` ->
`7.0.1`](https://renovatebot.com/diffs/npm/@fastify%2fstatic/6.12.0/7.0.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fstatic/7.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fstatic/7.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fstatic/6.12.0/7.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fstatic/6.12.0/7.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-static (@&#8203;fastify/static)</summary>

###
[`v7.0.1`](https://togithub.com/fastify/fastify-static/releases/tag/v7.0.1)

[Compare
Source](https://togithub.com/fastify/fastify-static/compare/v7.0.0...v7.0.1)

#### What's Changed

- build(deps-dev): bump
[@&#8203;fastify/compress](https://togithub.com/fastify/compress) from
6.5.0 to 7.0.0 by [@&#8203;dependabot](https://togithub.com/dependabot)
in
[https://github.com/fastify/fastify-static/pull/433](https://togithub.com/fastify/fastify-static/pull/433)
- Optimize `dirList` by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[https://github.com/fastify/fastify-static/pull/435](https://togithub.com/fastify/fastify-static/pull/435)
- fix: file not found errors when the root has a trailing slash by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[https://github.com/fastify/fastify-static/pull/436](https://togithub.com/fastify/fastify-static/pull/436)

**Full Changelog**:
fastify/fastify-static@v7.0.0...v7.0.1

###
[`v7.0.0`](https://togithub.com/fastify/fastify-static/releases/tag/v7.0.0)

[Compare
Source](https://togithub.com/fastify/fastify-static/compare/v6.12.0...v7.0.0)

#### What's Changed

- build(deps-dev): bump tsd from 0.29.0 to 0.30.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify-static/pull/424](https://togithub.com/fastify/fastify-static/pull/424)
- docs(readme): replace `fastify.io` links with `fastify.dev` by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-static/pull/425](https://togithub.com/fastify/fastify-static/pull/425)
- docs(readme): replace `fastify.io` links with `fastify.dev` by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-static/pull/426](https://togithub.com/fastify/fastify-static/pull/426)
- chore(package): fix repository url by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-static/pull/429](https://togithub.com/fastify/fastify-static/pull/429)
- chore: improve types for `setHeaders` option by
[@&#8203;EvanHahn](https://togithub.com/EvanHahn) in
[https://github.com/fastify/fastify-static/pull/428](https://togithub.com/fastify/fastify-static/pull/428)
- Upgrade glob to v10 by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[https://github.com/fastify/fastify-static/pull/406](https://togithub.com/fastify/fastify-static/pull/406)

#### New Contributors

- [@&#8203;EvanHahn](https://togithub.com/EvanHahn) made their first
contribution in
[https://github.com/fastify/fastify-static/pull/428](https://togithub.com/fastify/fastify-static/pull/428)

**Full Changelog**:
fastify/fastify-static@v6.12.0...v7.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on sunday" in timezone Asia/Shanghai,
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log [here](https://developer.mend.io/github/PKUHPC/SCOW).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@johanbook johanbook mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gurgunday @Eomm @Uzlopak @jsumners @mcollina