fix: stop duplication of path in template dir #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richdouglasevans
force-pushed
the
art-template-root-bug
branch
from
cede09e
to
7dac6f6
Compare
Closes fastify#437 When the `root` option is passed explicitly and the `art-template` engine is in use, the `root` value is being duplicated in the resolved template directory. This leads to an error like this: notice how `templates` is present twice in the path. ``` -{"statusCode":500,"error":"Internal Server Error","message":"template not found: ENOENT: no such file or directory, open '/home/rich/point-of-view/templates/templates/index.art'"} ``` The fix is to remove this duplication. The `resolveTemplateDir` function already uses any `root` option (if present) so there's no need to consider it again.
richdouglasevans
force-pushed
the
art-template-root-bug
branch
from
7dac6f6
to
6f9466a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #437
When the
rootoption is passed explicitly and theart-templateengine is in use, therootvalue is being duplicated in the resolved template directory.This leads to an error like this: notice how
templatesis present twice in the path.The fix is to remove this duplication. The
resolveTemplateDirfunction already uses anyrootoption (if present) so there's no need to consider it again.Checklist
npm run testandnpm run benchmarkand the Code of conduct