Curve support for Drawables #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Additions: - Created Pair class to handle returning 2 values at once, for generating point meshes with curves.
Breaking Changes: - Removed RenderStyle from Polygon2DBuilder constructors, as well as other Polygon2D static methods. Instead, it is configured from `Polygon2DBuilder#withRenderStyle(RenderStyle)`.
New Additions: - Support for converting Path2D objects with curves and multiple subpaths to Pointf[] arrays (with optional `alternateIndexes` stored in paired `Point[]`) - `DrawUtil#pointsOfPathWithAlt` specifically for getting both the points of the path and indicators of where curves/other path related functions are - Support for writing/reading polygons with curves with .psdf files Breaking Changes: - `DrawUtil#pointsOfPath` and variants no longer throw exceptions on unclosed paths. Bug Fixes: - (minor) Fixed issue in `DrawUtil#createPath` where `altIndexes` was not checked for emptiness Other Changes: - Optimized usages of `Polygon2D#getPoints` to be less taxing for standard tasks
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curve Support for Drawable
Closes #109, related to #10
Additions
alternateIndexesstored in pairedPoint[])DrawUtil#pointsOfPathWithAltspecifically for getting both the points of the path and indicators of where curves/other path related functions areBreaking Changes
Polygon2DBuilder#withRenderStyle(RenderStyle).DrawUtil#pointsOfPathand variants no longer throw exceptions on unclosed paths.Other Changes
Polygon2D#getPointsto be less taxing for standard tasks