Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for .ogg and .mp3 sound #245

Merged
merged 2 commits into from
Aug 21, 2022
Merged

Conversation

lucasstarsz
Copy link
Member

Add support for .ogg and .mp3 sound

Related to #23 (which needs an issue update)

Additions

  • added audio format re-encoding to support encoded files (.ogg, mp3)
  • added dependencies to include support the new audio formats
  • updated readme with .mp3 and .ogg support

Other Changes

  • updated the audio unit tests to test all the audio formats, with a focus on .ogg

Copy link
Member Author

@lucasstarsz lucasstarsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: update the dependencies used in the README.

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

71.4% 71.4% Coverage
0.0% 0.0% Duplication

@lucasstarsz
Copy link
Member Author

TODO: update the dependencies used in the README.

completed.

@lucasstarsz lucasstarsz merged commit 41f6101 into fastjengine:main Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant