Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples 1 #29

Merged
merged 32 commits into from
Jun 27, 2021
Merged

Examples 1 #29

merged 32 commits into from
Jun 27, 2021

Conversation

lucasstarsz
Copy link
Member

@lucasstarsz lucasstarsz commented Jun 27, 2021

Examples 1

Related to #20
Adds the following example programs:

  • engineconfig
  • keyboard
  • logging
  • polygon2d
  • text2d
  • model2d
  • modelreadwrite

Bug Fixes

In a list, briefly describe each bug you fixed. A link to the issue/pr where this bug is referenced is highly recommended.

  • fixed issue with trying to close display without it being displayed
  • fixed issue with keyChecker trying to start after shutting down

…itialized

`Keyboard.stop()` would try to call a method on `keyChecker`, but keyChecker had not been initialized yet. As such, it causes a null pointer.
To fix this, I've changed `keyChecker` to a final variable called `KeyChecker`, similar to that of `Mouse#MouseExecutor`.
Also added some stray documentation to SimpleManager
- polygon2d - Creating Polygon2D objects
- text2d - Creating Text2D objects
- model2d - Creating Model2D objects
- modelreadwrite - Reading & Writing Model2D objects
- logging - FastJ logging
- fastjengineconfig - FastJEngine Configuration
…itialized

`Keyboard.stop()` would try to call a method on `keyChecker`, but keyChecker had not been initialized yet. As such, it causes a null pointer.
To fix this, I've changed `keyChecker` to a final variable called `KeyChecker`, similar to that of `Mouse#MouseExecutor`.
Also added some stray documentation to SimpleManager
- polygon2d - Creating Polygon2D objects
- text2d - Creating Text2D objects
- model2d - Creating Model2D objects
- modelreadwrite - Reading & Writing Model2D objects
- logging - FastJ logging
- fastjengineconfig - FastJEngine Configuration
…itialized

`Keyboard.stop()` would try to call a method on `keyChecker`, but keyChecker had not been initialized yet. As such, it causes a null pointer.
To fix this, I've changed `keyChecker` to a final variable `KeyChecker`, similar to that of `Mouse#MouseExecutor`.
Also added some stray documentation to SimpleManager
- polygon2d - Creating Polygon2D objects
- text2d - Creating Text2D objects
- model2d - Creating Model2D objects
- modelreadwrite - Reading & Writing Model2D objects
- logging - FastJ logging
- fastjengineconfig - FastJEngine Configuration
- polygon2d - Creating Polygon2D objects
- text2d - Creating Text2D objects
- model2d - Creating Model2D objects
- modelreadwrite - Reading & Writing Model2D objects
- logging - FastJ logging
- fastjengineconfig - FastJEngine Configuration
…itialized

`Keyboard.stop()` would try to call a method on `keyChecker`, but keyChecker had not been initialized yet. As such, it causes a null pointer.
To fix this, I've changed `keyChecker` to a final variable `KeyChecker`, similar to that of `Mouse#MouseExecutor`.
Also added some stray documentation to SimpleManager
- polygon2d - Creating Polygon2D objects
- text2d - Creating Text2D objects
- model2d - Creating Model2D objects
- modelreadwrite - Reading & Writing Model2D objects
- logging - FastJ logging
- fastjengineconfig - FastJEngine Configuration
- polygon2d - Creating Polygon2D objects
- text2d - Creating Text2D objects
- model2d - Creating Model2D objects
- modelreadwrite - Reading & Writing Model2D objects
- logging - FastJ logging
- fastjengineconfig - FastJEngine Configuration
- polygon2d - Creating Polygon2D objects
- text2d - Creating Text2D objects
- model2d - Creating Model2D objects
- modelreadwrite - Reading & Writing Model2D objects
- logging - FastJ logging
- fastjengineconfig - FastJEngine Configuration
- polygon2d - Creating Polygon2D objects
- text2d - Creating Text2D objects
- model2d - Creating Model2D objects
- modelreadwrite - Reading & Writing Model2D objects
- logging - FastJ logging
- fastjengineconfig - FastJEngine Configuration
@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@lucasstarsz lucasstarsz marked this pull request as ready for review June 27, 2021 18:44
@lucasstarsz lucasstarsz merged commit 3e02e71 into main Jun 27, 2021
@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant