-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Docker Setup and Add Service Initialization Script for Fat Free CRM #1397
Open
Sgentz-26
wants to merge
24
commits into
fatfreecrm:master
Choose a base branch
from
Sgentz-26:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to make sure the database is running before it tries to connect to it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request includes significant updates to the Docker setup and documentation for the Fat Free CRM project. The changes aim to improve the Docker configuration, add a new script for service readiness, and enhance the documentation for better clarity and usability.
Docker Configuration Improvements
Dockerfile
:wait-for-it.sh
script to handle service readiness checks.docker-compose.yml
:links
withdepends_on
for better service management.New Script Addition
wait-for-it.sh
:Documentation Enhancements
README.md
:Why This Change Was Made
The previous Docker setup had several issues, including improper service sequencing and lack of documentation for deployment on Azure. By addressing these problems, this pull request makes the project more user-friendly and robust for deployment in various environments.