Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Docker Setup and Add Service Initialization Script for Fat Free CRM #1397

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

Sgentz-26
Copy link

Pull Request Description

This pull request includes significant updates to the Docker setup and documentation for the Fat Free CRM project. The changes aim to improve the Docker configuration, add a new script for service readiness, and enhance the documentation for better clarity and usability.

Docker Configuration Improvements

  • Dockerfile:
    • Refactored commands for improved readability and maintainability.
    • Added the wait-for-it.sh script to handle service readiness checks.
    • Updated the command to start the Rails server for better compatibility.
  • docker-compose.yml:
    • Replaced links with depends_on for better service management.
    • Updated port mappings and added environment variables.
    • Included a command to wait for the database service before initializing the application.

New Script Addition

  • wait-for-it.sh:
    • Added a script to wait for a specified host and port to be available before executing subsequent commands.
    • This ensures that the database service is ready before starting the application, reducing errors during initialization.

Documentation Enhancements

  • README.md:
    • Improved formatting for better readability.
    • Added hyperlinks for quick navigation.
    • Included detailed steps for deploying Fat Free CRM on an Azure Virtual Machine, covering:
      • Connecting to the VM.
      • Installing Docker.
      • Setting up an Apache reverse proxy.
      • Loading demo data into the database.
      • Sharing the VM with a group.

Why This Change Was Made

The previous Docker setup had several issues, including improper service sequencing and lack of documentation for deployment on Azure. By addressing these problems, this pull request makes the project more user-friendly and robust for deployment in various environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants