Override for table name fix for Rails 7.1 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherrypicked commit from Ransack 4.1.1 for Rails 7.1 activerecord-hackery/ransack@eac3c37
stanleylhs
changed the title
CloCkWeRX
approved these changes
Sep 12, 2024
|
Anything stopping us from just updating to 4.1.1+? |
This is the issue @steveyken is having |
|
I've created #26 to handle the upgrade from v3 to v4. In the meantime, this is a suitable monkey patch fix to provide Rails 7.1 compatibility. |
|
Ah, I should have made comments in the code about this being a monkey patch, say removed this after v4 upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypicked commit from Ransack 4.1.1 for Rails 7.1 as table_name is deprecated.
activerecord-hackery/ransack@eac3c37