-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for custom tablist header and footer #513
base: main
Are you sure you want to change the base?
Changes from 13 commits
c016d23
35babb7
a8fbd38
e4507b1
ba952b3
db7473a
48f8f42
22f2902
486dd86
7e0535f
45d01df
3a96ed0
3c3f707
b0c2320
f6f8675
abe25d8
342dba2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
use base::Gamemode; | ||
use base::{Gamemode, Text}; | ||
|
||
use crate::favicon::Favicon; | ||
|
||
|
@@ -28,6 +28,12 @@ pub struct Options { | |
/// The default gamemode for new players. | ||
pub default_gamemode: Gamemode, | ||
|
||
/// The default tablist header. | ||
pub tablist_header: Text, | ||
|
||
/// The default tablist footer. | ||
pub tablist_footer: Text, | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Then how do I get it from config to use it for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nevermind, got it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can pass it to register(game) function, or even better, make |
||
/// Proxy IP forwarding mode | ||
pub proxy_mode: Option<ProxyMode>, | ||
// HMAC key used with Velocity IP forwarding. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
use libcraft_text::Text; | ||
|
||
#[derive(Debug, Clone)] | ||
pub struct TablistHeaderFooter { | ||
pub header: Text, | ||
pub footer: Text, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#522 is now merged, so quill-compatible events should be in
quill/common/srs/events/change.rs
, implement Serialize, Deserialize, Clone, be defined inquill/common/src/component.rs
inHostComponent
enum and havebincode_component_impl!
in the end.