Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ki rev #7

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Ki rev #7

wants to merge 16 commits into from

Conversation

kweav
Copy link
Contributor

@kweav kweav commented Oct 24, 2024

Review of the following files:

  • index.qmd
    • Looks good, no changes there.
  • 01-intro.qmd
    • Added to references.bib because reference had the question mark
    • Changed the ottrpal slide links to link to the containers slide deck
    • Added an ottrpal slide link pointing to the github actions/automation slide deck with qr codes for the pre-req courses
    • switched out language for github actions/automation for containers.
  • 02-why-containers.qmd
    • Noted two spots where I think material needs to be added

    • Changed some language, added some phrases

    • Not sure I understood these two paragraphs

      In science, more variables means we’re lacking true clarity in what we are observing. More variables means things are messier. And reproducibility is the pillar of how science works.

      Science progresses when data and hypotheses are put through these levels thoroughly and sequentially. If results are not repeatable, they won’t be reproducible or replicable.

Questions:

  • Do the ottrpal included slides need alt text?

@kweav kweav requested a review from cansavvy October 24, 2024 19:42
Copy link
Contributor

github-actions bot commented Oct 24, 2024

No broken url errors! 🎉
Comment updated at 2024-10-30-23:56:05 with changes from dfd6414

Copy link
Contributor

github-actions bot commented Oct 24, 2024

No spelling errors! 🎉
Comment updated at 2024-10-30-23:56:06 with changes from dfd6414

Copy link
Contributor

github-actions bot commented Oct 24, 2024

Re-rendered previews from the latest commit:

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2024-10-30 with changes from the latest commit dfd6414

@kweav
Copy link
Contributor Author

kweav commented Oct 24, 2024

for broken url errors!

I see the "broken URL" in the ignore-urls.txt file. I can't tell why it's not being ignored. Looked through the workflow files and would really appreciate some guidance on figuring out what I'm missing.

@kweav
Copy link
Contributor Author

kweav commented Oct 24, 2024

Now that the references.bib has the reference that's used in the first sections, do you like how it's rendering at the bottom of the page? Do you want like a header above it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant