Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom JSON serialization of TipSetKey for array-of-CIDs #756

Open
wants to merge 3 commits into from

fixup! Custom JSON serialization of TipSetKey for array-of-CIDs

5c25653
Select commit
Loading
Failed to load commit list.
Open

Custom JSON serialization of TipSetKey for array-of-CIDs #756

fixup! Custom JSON serialization of TipSetKey for array-of-CIDs
5c25653
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 27, 2024 in 0s

69.56% (-0.12%) compared to c2f99cf

View this Pull Request on Codecov

69.56% (-0.12%) compared to c2f99cf

Details

Codecov Report

Attention: Patch coverage is 84.21053% with 9 lines in your changes missing coverage. Please review.

Project coverage is 69.56%. Comparing base (c2f99cf) to head (5c25653).

Files with missing lines Patch % Lines
gpbft/chain.go 85.36% 4 Missing and 2 partials ⚠️
gpbft/gpbft.go 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
- Coverage   69.68%   69.56%   -0.12%     
==========================================
  Files          74       74              
  Lines        7494     7551      +57     
==========================================
+ Hits         5222     5253      +31     
- Misses       1863     1884      +21     
- Partials      409      414       +5     
Files with missing lines Coverage Δ
certs/certs.go 92.68% <ø> (ø)
gpbft/gpbft.go 89.12% <81.25%> (-0.15%) ⬇️
gpbft/chain.go 87.87% <85.36%> (-0.55%) ⬇️

... and 2 files with indirect coverage changes