Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update filecoin-ffi to v1.30.0-rc1 #12476

Merged
merged 2 commits into from
Sep 25, 2024
Merged

chore: update filecoin-ffi to v1.30.0-rc1 #12476

merged 2 commits into from
Sep 25, 2024

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Sep 17, 2024

Related Issues

Proposed Changes

Update filecoin-ffi to v1.30.0-rc1

Checklist

Before you mark the PR ready for review, please make sure that:

chore: update filecoin-ffi to v1.30.0-dev2
@rjan90 rjan90 self-assigned this Sep 17, 2024
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we hold off until filecoin-project/filecoin-ffi#491 is resolved since this doesn't move us much closer to not requiring a recompile

@BigLep
Copy link
Member

BigLep commented Sep 24, 2024

@rjan90 : can you merge once filecoin-project/filecoin-ffi#492 is merged?

@rjan90 rjan90 changed the title chore: update filecoin-ffi to v1.30.0-dev2 chore: update filecoin-ffi to v1.30.0-rc1 Sep 25, 2024
chore: bump filecoin-ffi to v1.30.0-rc1
@rjan90
Copy link
Contributor Author

rjan90 commented Sep 25, 2024

I have bumped the filecoin-ffi version to v1.30.0-rc1 in this commit: 30142ae, which should unblock us needing to recompile.

@rjan90 rjan90 requested a review from rvagg September 25, 2024 07:39
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 confirmed that this does download pre-compiled binaries

@rjan90 rjan90 merged commit e26d09b into master Sep 25, 2024
82 checks passed
@rjan90 rjan90 deleted the phi/bump-ffi branch September 25, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants