Skip to content

Commit

Permalink
astdelux: remove BDF_HISCORE_SUPPORTED again
Browse files Browse the repository at this point in the history
  • Loading branch information
@barbudreadmon
barbudreadmon committed Sep 24, 2023
1 parent fa161b8 commit 0b452e5
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions src/burn/drv/pre90s/d_asteroids.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1599,6 +1599,9 @@ struct BurnDriver BurnDrvHyperspc = {
640, 480, 4, 3
};

// note: the astdelux entry in hiscore.dat breaks the game and seems wrong (the 3rd area is saving game timers ?),
// for that reason and also because it is unnecessary (the hiscores are persisted through nvram anyway),
// we prefer keeping the BDF_HISCORE_SUPPORTED flag disabled

// Asteroids Deluxe (rev 3)

Expand All @@ -1621,7 +1624,7 @@ struct BurnDriver BurnDrvAstdelux = {
"astdelux", NULL, NULL, NULL, "1980",
"Asteroids Deluxe (rev 3)\0", NULL, "Atari", "Miscellaneous",
NULL, NULL, NULL, NULL,
BDF_GAME_WORKING | BDF_HISCORE_SUPPORTED, 2, HARDWARE_MISC_PRE90S, GBF_SHOOT | GBF_VECTOR, 0,
BDF_GAME_WORKING /* | BDF_HISCORE_SUPPORTED */, 2, HARDWARE_MISC_PRE90S, GBF_SHOOT | GBF_VECTOR, 0,
NULL, astdeluxRomInfo, astdeluxRomName, NULL, NULL, NULL, NULL, AstdeluxInputInfo, AstdeluxDIPInfo,
AstdeluxInit, DrvExit, DrvFrame, DrvDraw, DrvScan, &DrvRecalc, 0x2000,
640, 480, 4, 3
Expand All @@ -1648,7 +1651,7 @@ struct BurnDriver BurnDrvAstdelux2 = {
"astdelux2", "astdelux", NULL, NULL, "1980",
"Asteroids Deluxe (rev 2)\0", NULL, "Atari", "Miscellaneous",
NULL, NULL, NULL, NULL,
BDF_GAME_WORKING | BDF_CLONE | BDF_HISCORE_SUPPORTED, 2, HARDWARE_MISC_PRE90S, GBF_SHOOT | GBF_VECTOR, 0,
BDF_GAME_WORKING | BDF_CLONE /* | BDF_HISCORE_SUPPORTED */, 2, HARDWARE_MISC_PRE90S, GBF_SHOOT | GBF_VECTOR, 0,
NULL, astdelux2RomInfo, astdelux2RomName, NULL, NULL, NULL, NULL, AstdeluxInputInfo, AstdeluxDIPInfo,
AstdeluxInit, DrvExit, DrvFrame, DrvDraw, DrvScan, &DrvRecalc, 0x2000,
640, 480, 4, 3
Expand Down Expand Up @@ -1676,7 +1679,7 @@ struct BurnDriver BurnDrvAstdelux1 = {
"astdelux1", "astdelux", NULL, NULL, "1980",
"Asteroids Deluxe (rev 1)\0", NULL, "Atari", "Miscellaneous",
NULL, NULL, NULL, NULL,
BDF_GAME_WORKING | BDF_CLONE | BDF_HISCORE_SUPPORTED, 2, HARDWARE_MISC_PRE90S, GBF_SHOOT | GBF_VECTOR, 0,
BDF_GAME_WORKING | BDF_CLONE /* | BDF_HISCORE_SUPPORTED */, 2, HARDWARE_MISC_PRE90S, GBF_SHOOT | GBF_VECTOR, 0,
NULL, astdelux1RomInfo, astdelux1RomName, NULL, NULL, NULL, NULL, AstdeluxInputInfo, AstdeluxDIPInfo,
AstdeluxInit, DrvExit, DrvFrame, DrvDraw, DrvScan, &DrvRecalc, 0x2000,
640, 480, 4, 3
Expand Down

1 comment on commit 0b452e5

@barbudreadmon
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shaunquick i might as well warn you about this, some games have seemingly broken entries in hiscore.dat
i actually removed this flag once in d49b309 but i should also have added a note to prevent his return :)

Please sign in to comment.