Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1379

Closed
wants to merge 1 commit into from
Closed

Update README.md #1379

wants to merge 1 commit into from

Conversation

AmineDjeghri
Copy link

No description provided.

@ANGkeith
Copy link
Collaborator

ANGkeith commented Oct 14, 2024

it's kinda already documented. have you seen this?
https://github.com/firecow/gitlab-ci-local?tab=readme-ov-file#project-file-variables

how about we make some re-arrangement* ? do you think the following will be clearer ?
image

@AmineDjeghri
Copy link
Author

The only thing that bothers me (but it might be only me) is that we have a section for dotenv at the beginning. So I don't know if the users will see the second section .

Thank you again for this feature !

@ANGkeith
Copy link
Collaborator

The only thing that bothers me (but it might be only me) is that we have a section for dotenv at the beginning.

yeah.. i got confused by it initially as well haha..

@firecow
Copy link
Owner

firecow commented Oct 15, 2024

@AmineDjeghri Please merge master into your branch

@AmineDjeghri
Copy link
Author

@firecow Done !

@firecow
Copy link
Owner

firecow commented Nov 22, 2024

@AmineDjeghri Can you merge with origin/master again please

@firecow firecow closed this Dec 1, 2024
@firecow
Copy link
Owner

firecow commented Dec 1, 2024

Reopen if you get back to this

@AmineDjeghri
Copy link
Author

I will try to work on it this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants