Don't wait "losetup -D" #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The concurrency group could cause a deadlock and we no longer make a bunch of loopback devices during the tests. Fixes firecracker-microvm#570. Signed-off-by: Kazuyoshi Kato <[email protected]>
| # With that we can now clean up loop devices before starting jobs to ensure | ||
| # we don't hit the loop device limit | ||
| # Just in case, list loopback devices to make sure there are no leaks. | ||
| # We probably should move that to metrics later. |
There was a problem hiding this comment.
Is there an issue for this move just so we don't forget?
austinvazquez
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concurrency group could cause a deadlock and we no longer make a
bunch of loopback devices during the tests.
Signed-off-by: Kazuyoshi Kato [email protected]
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.