Separate TestMultipleVMs_Isolated from other tests #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzys
force-pushed
the
reduce-vms
branch
8 times, most recently
from
bfe3789 to
821444e
Compare
runtime/service_integ_test.go
Outdated
Comment on lines
287
to
279
| // One hour should be enough to start a VM, regardless of the load of | ||
| // the underlying host. | ||
| const createVMTimeout = 10 * time.Minute |
There was a problem hiding this comment.
Comment says one hour but code is ten minutes.
austinvazquez
approved these changes
May 23, 2022
kzys
force-pushed
the
reduce-vms
branch
10 times, most recently
from
69c4649 to
5ef78ac
Compare
kzys
changed the title
kzys
force-pushed
the
reduce-vms
branch
7 times, most recently
from
5c336b5 to
b17aec0
Compare
kzys
force-pushed
the
reduce-vms
branch
2 times, most recently
from
2f8ac08 to
fb8e00f
Compare
This test separates TestMultipleVMs_Isolated's 100 VMs run from other tests by - Changing the number of VMs from 100 to 10 in the runtime tests - Keeping 100 VMs run as a separate job with its own concurrency group. In addition to that, the test increases the number of VMs slowly, instead of running 100 VMs from the beginning to figure out the breaking point. Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test separates TestMultipleVMs_Isolated's 100 VMs run from other
tests by
In addition to that, the test increases the number of VMs slowly,
instead of running 100 VMs from the beginning to figure out the breaking
point.
Signed-off-by: Kazuyoshi Kato [email protected]
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.