Make agent static build the default for host build as well #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When following the getting started guide, the commands are all executed on the host and the agent built is dynamically linked. This will trigger an error when running a container as the microVM image's glibc version will likely not match the one from the host. Setting STATIC_BUILD to on for the host as is done for the docker build ensure that the agent is suitable for use by the microVM.Ensure agent is build statically in all cases
|
thank you, I was facing the same error and this helped me fix it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #472
Description of changes:
Change the default agent build type when done on host to static as is done when using Docker. This will ensure that people have a working version of the agent when building the microVM image.
The build can still be turned back to dynamic by calling
make STATIC_AGENT=.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.