Upgrade firecracker from v1.1.0 to v.1.4.1 #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update firecracker-go-sdk dependency Remove devtool strip which has been removed in latest firecracker release Signed-off-by: Tony Fang <[email protected]>
Before the change, we relied on Firecracker's devtool to build a custom kernel with our configs (which add FUSE support). The devtool's build_kernel function is broken in Firecracker 1.4.1 and is completely replaced by a non-containerized build script in main. Rather than trying to get Firecracker's internal dev tooling to work for our purposes, this change takes just the necessary scripts from Firecracker to build a kernel in a container. Signed-off-by: Kern Walster <[email protected]>
Signed-off-by: Kern Walster <[email protected]>
For some reason, waiting for the task exit before waiting for the rngtest outside the container causes rngtest's stdin to block forever. Signed-off-by: Kern Walster <[email protected]>
|
@Kern-- PR needs a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
carry of #757
Upgrade firecracker from v1.1.0 to v.1.4.1
Firecracker diff firecracker-microvm/firecracker@v1.1.0...v1.4.1
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.