Added env's to be able to configure timouts #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nmeyerhans @xibz @sipsma PTAL |
samuelkarp
reviewed
Dec 18, 2019
xibz
reviewed
Dec 19, 2019
Zyqsempai
force-pushed
the
164-added-configurable-timeouts
branch
from
06db74e to
f04d482
Compare
|
@samuelkarp Done. |
nmeyerhans
reviewed
Dec 19, 2019
xibz
reviewed
Dec 19, 2019
xibz
reviewed
Dec 19, 2019
samuelkarp
reviewed
Dec 19, 2019
Zyqsempai
force-pushed
the
164-added-configurable-timeouts
branch
3 times, most recently
from
2db1d36 to
88fc389
Compare
|
Guys, PTAL |
nmeyerhans
suggested changes
Dec 20, 2019
samuelkarp
reviewed
Dec 20, 2019
Signed-off-by: Boris Popovschi <[email protected]>
Zyqsempai
force-pushed
the
164-added-configurable-timeouts
branch
from
88fc389 to
5166432
Compare
|
Take a final look guys;) |
nmeyerhans
approved these changes
Dec 23, 2019
samuelkarp
approved these changes
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Boris Popovschi [email protected]
Issue #164
Description of changes:
Added
FIRECRACKER_INIT_TIMEOUT_SECONDSenv to configure init timeouts andFIRECRACKER_REQUEST_TIMEOUT_MILLISECONDSfor request timeouts.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.