Skip to content

Commit

Permalink
fix: ensure ci artifacts are present when using devtool sandbox
Browse files Browse the repository at this point in the history
Without ensure_ci_artifacts called inside cmd_sandbox, you will see an
index out of bounds errors during set up of the argument parser, since
build/img will be an empty directory (e.g. there are no kernels to
select, and the -1 index will be out of bounds).

Reported-by: Jack Thomson <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
  • Loading branch information
roypat committed Nov 27, 2024
1 parent 63ea863 commit 4c33853
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tools/devtool
Original file line number Diff line number Diff line change
Expand Up @@ -890,6 +890,7 @@ cmd_sh() {

cmd_sandbox() {
cmd_build --release
ensure_ci_artifacts
cmd_sh "tmux new env PYTEST_ADDOPTS=--pdbcls=IPython.terminal.debugger:TerminalPdb PYTHONPATH=tests IPYTHONDIR=\$PWD/.ipython ipython -i ./tools/sandbox.py $@"
}

Expand Down

0 comments on commit 4c33853

Please sign in to comment.