Skip to content

Commit

Permalink
fix: properly clean up tmp dir after shared build
Browse files Browse the repository at this point in the history
Building the A/B binaries happens in a tmpdir, which we try to delete at
the end. But we create files in the tmpdir from a privileged docker
container, so to delete this tmpdir we also need elevated privileges

Signed-off-by: Patrick Roy <[email protected]>
  • Loading branch information
roypat committed Dec 12, 2024
1 parent 9455ed0 commit 8c7ee82
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/devtool
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ cmd_build() {
git branch -D $branch_name
mkdir -p build/"$revision"
cp $tmp_dir/build/cargo_target/$(uname -m)-unknown-linux-$libc/$profile/* build/"$revision"
rm -rf $tmp_dir
cmd_sh "rm -rf $tmp_dir"
fi

return $ret
Expand Down

0 comments on commit 8c7ee82

Please sign in to comment.