Final PVH fixups #4073
Merged
Final PVH fixups #4073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/pvh #4073 +/- ##
===============================================
- Coverage 84.86% 84.08% -0.79%
===============================================
Files 223 251 +28
Lines 25772 28274 +2502
===============================================
+ Hits 21871 23773 +1902
- Misses 3901 4501 +600
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roypat
force-pushed
the
pvh-tests
branch
2 times, most recently
from
de3083a to
8be04a4
Compare
roypat
force-pushed
the
pvh-tests
branch
3 times, most recently
from
ce3237e to
b096346
Compare
roypat
force-pushed
the
pvh-tests
branch
7 times, most recently
from
18cdd9a to
9a2db96
Compare
roypat
force-pushed
the
pvh-tests
branch
4 times, most recently
from
1efb582 to
64b1bb5
Compare
|
I'm putting this back into draft until the initrd issues are resolved |
3 tasks
Enabling CONFIG_XEN_PVH=y is for booting on the actual Xen hypervisor. To boot using PVH on a non-Xen hypervisor, set CONFIG_PVH=y. Signed-off-by: Patrick Roy <[email protected]>
The feature branch is so old that during rebase it got moved into the 1.8 section. Move it back to the unreleased section. Signed-off-by: Patrick Roy <[email protected]>
With PVH support, we are passing around an `EntryPoint` structure, not just an address. Extract the address from the struct, and pass it to gdb::gdb_thread instead to fix compilation. A aarch64 unittest was missing a `GuestAddress` import. Signed-off-by: Patrick Roy <[email protected]>
roypat
force-pushed
the
pvh-tests
branch
2 times, most recently
from
316b7ea to
b5eaf92
Compare
Mainly clippy and mdformat have changed since the feature branch was created. Signed-off-by: Patrick Roy <[email protected]>
Use test_api_happy_start to assert that the log message that indicates usage of PVH boot protocol is present. Only x86_64 guests support PVH boot, and on ARM we do not emit any log messages, so restrict the assertion to x86_64 platforms. Signed-off-by: Patrick Roy <[email protected]>
Hardcoding main means the test looks at the wrong range of commits for feature branches, which can result in problem if feature branches are long-lived. Signed-off-by: Patrick Roy <[email protected]>
roypat
requested review from
xmarcalx,
kalyazin,
pb8o and
Manciukic
as code owners
roypat
added
the
Status: Awaiting review
ShadowCurse
approved these changes
Nov 11, 2024
bchalios
approved these changes
Nov 11, 2024
pb8o
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring the feature branch up-to-date with all changes that happened in
mainsince it was last updated, and which didn't show up as a merge conflict. Also do some minor doc fixes, and add integration testing.Since these days all our CI kernels are compiled with
CONFIG_PVH=y, integration testing is just a matter of adding an assert to verify that PVH boot mode is indeed being used. We are not adding FreeBSD tests to our CI, as we have no easy means for maintaining FreeBSD artifacts, and last time I checked (which admittedly was August 23), it also didn't boot on AMD instances.See also #3041
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.