test: Print error message if aws cli not available #4105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, devtool test silently fails if aws cli is not installed, which results in CI artifacts not getting downloaded, which results in all tests being skipped. Since the error message from downloading artifacts is burried in other output, explicitly abort. Signed-off-by: Patrick Roy <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4105 +/- ##
=======================================
Coverage 82.35% 82.35%
=======================================
Files 225 225
Lines 28469 28469
=======================================
Hits 23447 23447
Misses 5022 5022
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roypat
added
the
Status: Awaiting review
pb8o
approved these changes
Sep 13, 2023
wearyzen
approved these changes
Sep 13, 2023
|
could you please update the PR checklist before merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently, devtool test silently fails if aws cli is not installed, which results in CI artifacts not getting downloaded, which results in all tests being skipped. Since the error message from downloading artifacts is burried in other output, explicitly abort.
Reason
We have received multiple reports of all integration tests being skipped due to "empty fixtures", which happens if artifacts fail to download. They can usually be traced back to aws cli not being installed, so make this case a bit more obvious.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.