snapshot: deprecate forward compatibility #4122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchalios
requested review from
xmarcalx,
kalyazin,
pb8o and
wearyzen
as code owners
bchalios
force-pushed
the
drop_snapshot_forward_compatibility
branch
from
a67d36f to
7350c65
Compare
bchalios
added
the
Status: Awaiting review
kalyazin
previously approved these changes
Sep 21, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4122 +/- ##
=======================================
Coverage 83.10% 83.11%
=======================================
Files 225 225
Lines 28545 28559 +14
=======================================
+ Hits 23722 23736 +14
Misses 4823 4823
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ShadowCurse
reviewed
Sep 21, 2023
bchalios
force-pushed
the
drop_snapshot_forward_compatibility
branch
from
7350c65 to
8b070ad
Compare
We are not dropping support for this now. We are calling it deprecated. I don't think we should remove anything at this point. Am I missing something? |
|
Oh yeah, my mistake. We should remove it in the next release, not this one. |
ShadowCurse
reviewed
Sep 21, 2023
ShadowCurse
reviewed
Sep 21, 2023
bchalios
force-pushed
the
drop_snapshot_forward_compatibility
branch
2 times, most recently
from
9e80c09 to
178806f
Compare
Forward compatibility refers to the ability of Firecracker to create snapshots for older version formats. This feature is now deprecated and it will be removed in a subsequent release. Snapshot support is in developer preview, so dropping support for it does not require us to increase Firecracker's major version. In practice, deprecating this feature means that we deprecate the `version` field of the `PUT /snapshot/create` request. This commit, adds the "deprecated" header in the response of the endpoint if `version` is defined and documents the deprecation in CHANGELOG and snapshot documentation. Signed-off-by: Babis Chalios <[email protected]>
bchalios
force-pushed
the
drop_snapshot_forward_compatibility
branch
from
178806f to
20a4dc8
Compare
roypat
approved these changes
Sep 22, 2023
kalyazin
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Forward compatibility refers to the ability of Firecracker to create snapshots for older version formats. This feature is now deprecated and it will be removed in a subsequent release. Snapshot support is in developer preview, so dropping support for it does not require us to increase Firecracker's major version.
In practice, deprecating this feature means that we deprecate the
versionfield of thePUT /snapshot/createrequest. This commit, adds the "deprecated" header in the response of the endpoint ifversionis defined and documents the deprecation in CHANGELOG and snapshot documentation.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.