fix:import testing framework for few tools scripts #4130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4130 +/- ##
=======================================
Coverage 82.29% 82.29%
=======================================
Files 225 225
Lines 28470 28470
=======================================
Hits 23429 23429
Misses 5041 5041
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roypat
previously approved these changes
Sep 25, 2023
roypat
reviewed
Sep 25, 2023
wearyzen
added
the
Status: Awaiting review
pb8o
reviewed
Sep 25, 2023
roypat
approved these changes
Sep 25, 2023
pb8o
approved these changes
Sep 25, 2023
rearrange changes added in #4089 so that the testing framework is available and the tools scripts work as expected. Signed-off-by: Sudan Landge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Make testing framework available so that the few tools scripts using them work as expected.
Reason
changes added in #4089 breaks cross snapshot restore tests.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
If a specific issue led to this PR, this PR closes the issue.Any required documentation changes (code and docs) are included in this PR.API changes follow the Runbook for Firecracker API changes.User-facing changes are mentioned inCHANGELOG.md.NewTODOs link to an issue.rust-vmm.