Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v1.5.0 #4158

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

roypat
Copy link
Contributor

@roypat roypat commented Oct 9, 2023

Commit generated by ./tools/release-prepare.sh 1.5.0. Only manual change was removing dependabot from CREDITS.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Oct 9, 2023
pb8o
pb8o previously approved these changes Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2e22cf2) 82.99% compared to head (1eb29f7) 82.99%.

Additional details and impacted files
@@                Coverage Diff                @@
##           firecracker-v1.5    #4158   +/-   ##
=================================================
  Coverage             82.99%   82.99%           
=================================================
  Files                   223      223           
  Lines                 28448    28448           
=================================================
  Hits                  23609    23609           
  Misses                 4839     4839           
Flag Coverage Δ
4.14-c7g.metal 78.52% <ø> (-0.01%) ⬇️
4.14-m5d.metal 80.33% <ø> (ø)
4.14-m6a.metal 79.46% <ø> (ø)
4.14-m6g.metal 78.53% <ø> (ø)
4.14-m6i.metal 80.31% <ø> (ø)
5.10-c7g.metal 81.44% <ø> (ø)
5.10-m5d.metal 83.00% <ø> (+0.01%) ⬆️
5.10-m6a.metal 82.23% <ø> (ø)
5.10-m6g.metal 81.44% <ø> (ø)
5.10-m6i.metal 82.99% <ø> (ø)
6.1-c7g.metal 81.44% <ø> (ø)
6.1-m5d.metal 83.00% <ø> (ø)
6.1-m6a.metal 82.23% <ø> (ø)
6.1-m6g.metal 81.44% <ø> (ø)
6.1-m6i.metal 82.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zulinx86 zulinx86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the commit message for the addition of snapshot-editor tool?
Are we going to automate the removal of dependabot from CREDITS.md on the main branch?

Update the versions in .tomls and CHANGELOG.md

Signed-off-by: Patrick Roy <[email protected]>
Was forgotten to be added before.

Signed-off-by: Patrick Roy <[email protected]>
@roypat
Copy link
Contributor Author

roypat commented Oct 10, 2023

Could you update the commit message for the addition of snapshot-editor tool? Are we going to automate the removal of dependabot from CREDITS.md on the main branch?

oops, fixed.

put the dependabot thing on my todo list for small fixes to the release process!

@roypat roypat merged commit d096bcd into firecracker-microvm:firecracker-v1.5 Oct 10, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants