Tests: Misc fixes and documentation #4160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb8o
added
Priority: Low
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4160 +/- ##
=======================================
Coverage 83.02% 83.02%
=======================================
Files 222 222
Lines 28635 28635
=======================================
Hits 23775 23775
Misses 4860 4860
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pb8o
force-pushed
the
test-misc-fixes
branch
7 times, most recently
from
40f47fd to
b4de25c
Compare
pb8o
added
Status: Awaiting review
kalyazin
reviewed
Oct 17, 2023
roypat
reviewed
Oct 18, 2023
Turns out bin_cloner is not needed to run Firecracker under pytest. Could be it was only required by older versions of Python, but not anymore. Running directly the jailer with PID namespaces is closer to our recommended prod setup. Signed-off-by: Pablo Barbáchano <[email protected]>
Clean a bit the Microvm constructor by moving the uuid optional parameters to factory defaults, and always expecting `pathlib.Path` Signed-off-by: Pablo Barbáchano <[email protected]>
The retry library has been unmaintained for a while with its last release in 2016. Replace with tenacity, which is the spiritual successor. Signed-off-by: Pablo Barbáchano <[email protected]>
Use `ip netns exec` when calling the ssh process. This means the pytest thread does not have to switch network namespace and back. We already use the same approach just below for the tap device, so now there is a single way to enter a network namespace. Also drop the nsenter Python package dependency, which seems unmaintained. Signed-off-by: Pablo Barbáchano <[email protected]>
Since we added the option to use a different binary than the workspace in 83fcb04, add a property to capture the name of the binary. Signed-off-by: Pablo Barbáchano <[email protected]>
Can be useful to test against different Firecracker versions. Signed-off-by: Pablo Barbáchano <[email protected]>
Document some of the sandbox subcommand options. Signed-off-by: Pablo Barbáchano <[email protected]>
In get_host_os, if there are not enough components, return None. Signed-off-by: Pablo Barbáchano <[email protected]>
roypat
approved these changes
Oct 18, 2023
kalyazin
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Some small fixes to the tests regarding tech debt, and making it easier to run for other Firecracker binaries or outside the dev contrainer.
Reason
To decrease technical debt and simplify the codebase.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.