chore(devctr): add qemu vhost-user-blk backend #4167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4167 +/- ##
=======================================
Coverage 82.98% 82.98%
=======================================
Files 223 223
Lines 28508 28508
=======================================
Hits 23656 23656
Misses 4852 4852
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kalyazin
force-pushed
the
backend_v2
branch
2 times, most recently
from
0ea7594 to
85e04a6
Compare
4 tasks
kalyazin
added
the
Status: Awaiting review
pb8o
reviewed
Oct 11, 2023
pb8o
previously approved these changes
Oct 11, 2023
pb8o
reviewed
Oct 11, 2023
Builds the backend from source at the devctr build time and installs the binary at /usr/local/bin/vhost-user-blk . This also installs a runtime dependency: libglib2.0-dev . Increases the image size by about 80M. Signed-off-by: Nikita Kalyazin <[email protected]>
The new warnings are likely caused by the devctr update. Signed-off-by: Nikita Kalyazin <[email protected]>
roypat
approved these changes
Oct 11, 2023
pb8o
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Builds the backend from source at the devctr build time and installs the binary at
/usr/local/bin/vhost-user-blk.This also installs a runtime dependency: libglib2.0-dev .
Increases the image size by about 80M.
Reason
Required for vhost-user-blk device testing.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] If a specific issue led to this PR, this PR closes the issue.[ ] Any required documentation changes (code and docs) are included in this PR.[ ] API changes follow the Runbook for Firecracker API changes.[ ] User-facing changes are mentioned inCHANGELOG.md.[ ] NewTODOs link to an issue.rust-vmm.