fix: move the logging message where it's effective #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4171 +/- ##
==========================================
+ Coverage 82.97% 82.99% +0.02%
==========================================
Files 221 221
Lines 28568 28567 -1
==========================================
+ Hits 23703 23709 +6
+ Misses 4865 4858 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pb8o
added
the
Status: Awaiting author
pb8o
force-pushed
the
fix-logging
branch
3 times, most recently
from
8e0da4a to
f385b2d
Compare
pb8o
added
Priority: Medium
JonathanWoollett-Light
previously approved these changes
Oct 16, 2023
Move the message after the logger has been configured, so it actually gets printed. Eliminate redundant message that outputs internal vmm crate version 0.1.0. Fixes: 96ed457, 332f218 Signed-off-by: Pablo Barbáchano <[email protected]>
JonathanWoollett-Light
previously approved these changes
Oct 17, 2023
xmarcalx
reviewed
Oct 17, 2023
xmarcalx
requested changes
Oct 17, 2023
pb8o
force-pushed
the
fix-logging
branch
3 times, most recently
from
2ecbc18 to
2b5e4bc
Compare
xmarcalx
requested changes
Oct 17, 2023
show-log-origin was turned on by the --show-level option. Use the correct flag to enable it. Fixes: 332f218 Signed-off-by: Pablo Barbáchano <[email protected]>
roypat
approved these changes
Oct 18, 2023
xmarcalx
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the message after the logger has been configured, so it actually gets printed.
Eliminate redundant message that outputs internal vmm crate version 0.1.0.
Fixes: 96ed457, 332f218
Changes
It can happen that the version printed is v0.1.0, instead of the expected version.
Reason
This behavior may confuse users of the logs.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.