Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add "deprecated" section to changelog #4174

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

roypat
Copy link
Contributor

@roypat roypat commented Oct 13, 2023

We want to separate these from the "changes" section.

Changes

...

Reason

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

We want to separate these from the "changes" section.

Signed-off-by: Patrick Roy <[email protected]>
@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Oct 13, 2023
Copy link
Contributor

@pb8o pb8o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also want a "Removed" section in the future. Not sure if it's worth adding now.

@roypat
Copy link
Contributor Author

roypat commented Oct 13, 2023

We may also want a "Removed" section in the future. Not sure if it's worth adding now.

Mh, yeah, we will definitely want it for major releases. Not sure if it makes sense to include in the template, given that for non-major releases it wont be used though

@roypat roypat merged commit f60faf5 into firecracker-microvm:main Oct 13, 2023
4 checks passed
@roypat roypat deleted the deprecations-section branch April 15, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants