Update removal policy of deprecated API elements #4181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As semantic versioning has several versions, points the link to v2.0.0-specific one for clarity. Signed-off-by: Takahiro Itazuri <[email protected]>
zulinx86
requested review from
xmarcalx,
kalyazin,
pb8o and
wearyzen
as code owners
zulinx86
added
the
Status: Awaiting review
zulinx86
changed the title
zulinx86
force-pushed
the
policy_update
branch
from
b96b12b to
17457ce
Compare
pb8o
previously approved these changes
Oct 16, 2023
Simplify and clarify the rules which we follow to remove deprecated API elements. See also GitHub discussion firecracker-microvm#4157. Signed-off-by: Takahiro Itazuri <[email protected]>
zulinx86
force-pushed
the
policy_update
branch
from
17457ce to
842e9b6
Compare
pb8o
approved these changes
Oct 16, 2023
wearyzen
approved these changes
Oct 16, 2023
wearyzen
reviewed
Oct 16, 2023
|
I should have kept this PR open for a week to accept comments from our customers. Sorry :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reason
Closes #4157 .
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] API changes follow the Runbook for Firecracker API changes.CHANGELOG.md.[ ] All added/changed functionality is tested.[ ] NewTODOs link to an issue.rust-vmm.