Add preliminary support for a Linux 6.1 guest kernel, plus kvm_ptp #4188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb8o
added
Priority: Low
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4188 +/- ##
=======================================
Coverage 82.94% 82.94%
=======================================
Files 221 221
Lines 28419 28419
=======================================
Hits 23572 23572
Misses 4847 4847
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pb8o
force-pushed
the
kvm-ptp
branch
8 times, most recently
from
0ff9fdb to
a581d19
Compare
Disabled some options that we don't seem to need for our integration tests. There's still options we can disable, but this already brings down the kernel size from - 5.10: 43.5 -> 26.0 (-35%) - 4.14: 20.5 -> 19.0 (- 8%) Signed-off-by: Pablo Barbáchano <[email protected]>
Those configs are not used anymore. The -ci- versions are the ones used. Signed-off-by: Pablo Barbáchano <[email protected]>
Preliminary support for a Linux 6.1 guest kernel. Started from the respective 5.10 kernel configs. Signed-off-by: Pablo Barbáchano <[email protected]>
Use the CPU model name rather than having instance types hardcoded. Signed-off-by: Pablo Barbáchano <[email protected]>
Convert the test to use sets of CPU features. This has two main benefits: 1) it is easy to see the differences of each set, and 2) if the test fails, it will print the difference of the sets, which helps troubleshooting. Signed-off-by: Pablo Barbáchano <[email protected]>
Add preliminary support for 6.1 guest kernel, but only limited to c7g instances and host kernel Linux 6.1. Also do not enable performance test checks for 6.1 guest kernels. Signed-off-by: Pablo Barbáchano <[email protected]>
We don't have an immediate use case for it, but this may help in troubleshooting use cases. Signed-off-by: Pablo Barbáchano <[email protected]>
Add kvm_ptp in aarch64 to match the x86_64 config. kvm_ptp was introduced in https://lore.kernel.org/all/[email protected]/ Signed-off-by: Pablo Barbáchano <[email protected]>
Corrected to use the new chrony URL. Signed-off-by: Pablo Barbáchano <[email protected]>
These timeouts are not needed, as we already have a 5 minute per test timeout, and the test itself takes around 3 minutes. Signed-off-by: Pablo Barbáchano <[email protected]>
Move the timeout per test, since we don't know a priori how many tests are going to run, depending on the supported host and guest kernels. Signed-off-by: Pablo Barbáchano <[email protected]>
roypat
approved these changes
Oct 23, 2023
bchalios
reviewed
Oct 23, 2023
There was a problem hiding this comment.
I've only have some questions regarding the trimmed options from the guest kernels' .config. I don't think it's really important because we can always re-introduce them, but I'd like us to discuss whether we really want to trim down all these options.
Also, it is not clear to me whether this trimming, as well as some other changes (I've commented where I found them) are related with this PR directly. For example, maybe they helped with test stability(?).
If these changes are ground-work for the actual changes the PR does, then fine (even though we might consider doing this in a separate PR). If it's just piggy-backing unrelated work, then that's ok but at the very least let's mention this clearly in the PR description. It would help with the review.
bchalios
approved these changes
Oct 23, 2023
wearyzen
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.