fix: Downgrade #![deny(...)] to #![warn(...)] #4244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4244 +/- ##
=======================================
Coverage 81.71% 81.71%
=======================================
Files 240 240
Lines 29239 29239
=======================================
Hits 23893 23893
Misses 5346 5346
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roypat
added
the
Status: Awaiting review
In our CI, we explicitly check that no warnings are present (by meanings of -Dwarnings during build tests). This means that there is no need to have #![deny(...)] instead of #![warn(...)] directives in the source code. On the other hand, having deny directives makes prototyping more annoying, as scrappy code will not compile until all compiler warnings are fixed (which might not neccessarily make sense when prototyping). See also firecracker-microvm#4106 Signed-off-by: Patrick Roy <[email protected]>
|
Opened rust-lang/rust-clippy#11822 |
JonathanWoollett-Light
approved these changes
Nov 16, 2023
ShadowCurse
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our CI, we explicitly check that no warnings are present (by meanings of -Dwarnings during build tests). This means that there is no need to have #![deny(...)] instead of #![warn(...)] directives in the source code. On the other hand, having deny directives makes prototyping more annoying, as scrappy code will not compile until all compiler warnings are fixed (which might not neccessarily make sense when prototyping).
See also #4106
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.