Guest vs host features check #4884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4884 +/- ##
=======================================
Coverage 84.10% 84.10%
=======================================
Files 251 251
Lines 28080 28080
=======================================
Hits 23616 23616
Misses 4464 4464
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ShadowCurse
force-pushed
the
guest_host_features_check
branch
6 times, most recently
from
64c7e72 to
e81248e
Compare
ShadowCurse
changed the title
ShadowCurse
added
the
Status: Awaiting review
ShadowCurse
force-pushed
the
guest_host_features_check
branch
from
e81248e to
41b2748
Compare
pb8o
reviewed
Oct 31, 2024
tests/integration_tests/functional/test_cpu_features_aarch64.py
Outdated
Show resolved
Hide resolved
roypat
reviewed
Oct 31, 2024
tests/integration_tests/functional/test_cpu_features_aarch64.py
Outdated
Show resolved
Hide resolved
ShadowCurse
force-pushed
the
guest_host_features_check
branch
from
41b2748 to
e813c62
Compare
kalyazin
reviewed
Oct 31, 2024
ShadowCurse
force-pushed
the
guest_host_features_check
branch
2 times, most recently
from
9593771 to
6ce3d2b
Compare
ShadowCurse
changed the title
ShadowCurse
force-pushed
the
guest_host_features_check
branch
6 times, most recently
from
8858049 to
c4ff6f8
Compare
pb8o
reviewed
Nov 4, 2024
pb8o
reviewed
Nov 4, 2024
ShadowCurse
force-pushed
the
guest_host_features_check
branch
from
c4ff6f8 to
e280ddb
Compare
pb8o
reviewed
Nov 4, 2024
Add test comparing host and guest default cpu features. Signed-off-by: Egor Lazarchuk <[email protected]>
Add test comparing host and guest default cpu features. Signed-off-by: Egor Lazarchuk <[email protected]>
Add `_x86_64` to the file name be consistent with aarch64 version. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
guest_host_features_check
branch
from
e280ddb to
986c755
Compare
kalyazin
approved these changes
Nov 6, 2024
pb8o
approved these changes
Nov 6, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add tests comparing host and guest default cpu features.
Reason
We want to know what is the difference between cpu features on the host and in the guest.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.