Minor queue size fixes #4887
Merged
Minor queue size fixes #4887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4887 +/- ##
=======================================
Coverage 84.10% 84.10%
=======================================
Files 251 251
Lines 28080 28080
=======================================
Hits 23616 23616
Misses 4464 4464
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ShadowCurse
force-pushed
the
minor_queue_size_fixes
branch
from
85e7eb3 to
3037c7b
Compare
ShadowCurse
added
Type: Fix
ShadowCurse
force-pushed
the
minor_queue_size_fixes
branch
3 times, most recently
from
95302c1 to
80f0300
Compare
Use `NET_QUEUE_SIZES` for `parsed_descriptors` in the `RxBuffers` instead of `FIRECRACKER_MAX_QUEUE_SIZE` Signed-off-by: Egor Lazarchuk <[email protected]>
Use `FIRECRACKER_MAX_QUEUE_SIZE` for default type alias. Use `L` const generic in the stub for `push_back` for kani. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
minor_queue_size_fixes
branch
from
80f0300 to
891ba57
Compare
bchalios
approved these changes
Nov 11, 2024
roypat
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Minor fixes for usage of constants in the virtio-net and iovec.
Reason
More maintainable code.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.