test(net): use iperf3-vsock to avoid iperf crashes on aarch64 #4893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4893 +/- ##
=======================================
Coverage 84.10% 84.10%
=======================================
Files 251 251
Lines 28080 28080
=======================================
Hits 23616 23616
Misses 4464 4464
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kalyazin
added
the
Status: Awaiting review
pb8o
previously approved these changes
Nov 6, 2024
kalyazin
changed the title
zulinx86
previously approved these changes
Nov 7, 2024
kalyazin
changed the title
pb8o
added
the
Priority: Medium
kalyazin
changed the title
If we supply an invalid iperf binary to the test it still passes. This adds checks for the command output. While doing that, increase the timeout to let the command finish without hitting it. Signed-off-by: Nikita Kalyazin <[email protected]>
We observe iperf3 3.16+ crashes on aarch64 when running the test. Use iperf3-vsock that we already build from source instead. Signed-off-by: Nikita Kalyazin <[email protected]>
kalyazin
changed the title
pb8o
approved these changes
Nov 7, 2024
zulinx86
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Use iperf3-vsock on host for the
test_high_ingress_traffictest instead of iperf3.Reason
We see crashes inside
test_high_ingress_trafficon aarch64 with both iperf3 3.16 (currently in devctr) and 3.17 (latest release).License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] If a specific issue led to this PR, this PR closes the issue.[ ] Any required documentation changes (code and docs) are included in thisPR.
[ ] API changes follow the Runbook for Firecracker API changes.[ ] User-facing changes are mentioned inCHANGELOG.md.[ ] NewTODOs link to an issue.contribution quality standards.
rust-vmm.