Update v1.10 branch with revert #4896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the firecracker group with 7 updates: | Package | From | To | | --- | --- | --- | | [thiserror](https://github.com/dtolnay/thiserror) | `1.0.65` | `1.0.67` | | [zerocopy](https://github.com/google/zerocopy) | `0.8.7` | `0.8.8` | | [syn](https://github.com/dtolnay/syn) | `2.0.85` | `2.0.87` | | [vhost](https://github.com/rust-vmm/vhost) | `0.12.1` | `0.13.0` | | [anstyle](https://github.com/rust-cli/anstyle) | `1.0.9` | `1.0.10` | | [cc](https://github.com/rust-lang/cc-rs) | `1.1.31` | `1.1.34` | | [thiserror-impl](https://github.com/dtolnay/thiserror) | `1.0.65` | `1.0.67` | Updates `thiserror` from 1.0.65 to 1.0.67 - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](dtolnay/thiserror@1.0.65...1.0.67) Updates `zerocopy` from 0.8.7 to 0.8.8 - [Release notes](https://github.com/google/zerocopy/releases) - [Changelog](https://github.com/google/zerocopy/blob/main/CHANGELOG.md) - [Commits](https://github.com/google/zerocopy/commits) Updates `syn` from 2.0.85 to 2.0.87 - [Release notes](https://github.com/dtolnay/syn/releases) - [Commits](dtolnay/syn@2.0.85...2.0.87) Updates `vhost` from 0.12.1 to 0.13.0 - [Release notes](https://github.com/rust-vmm/vhost/releases) - [Commits](rust-vmm/vhost@vhost-v0.12.1...vhost-v0.13.0) Updates `anstyle` from 1.0.9 to 1.0.10 - [Commits](rust-cli/anstyle@v1.0.9...v1.0.10) Updates `cc` from 1.1.31 to 1.1.34 - [Release notes](https://github.com/rust-lang/cc-rs/releases) - [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md) - [Commits](rust-lang/cc-rs@cc-v1.1.31...cc-v1.1.34) Updates `thiserror-impl` from 1.0.65 to 1.0.67 - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](dtolnay/thiserror@1.0.65...1.0.67) --- updated-dependencies: - dependency-name: thiserror dependency-type: direct:production update-type: version-update:semver-patch dependency-group: firecracker - dependency-name: zerocopy dependency-type: direct:production update-type: version-update:semver-patch dependency-group: firecracker - dependency-name: syn dependency-type: direct:production update-type: version-update:semver-patch dependency-group: firecracker - dependency-name: vhost dependency-type: direct:production update-type: version-update:semver-minor dependency-group: firecracker - dependency-name: anstyle dependency-type: indirect update-type: version-update:semver-patch dependency-group: firecracker - dependency-name: cc dependency-type: indirect update-type: version-update:semver-patch dependency-group: firecracker - dependency-name: thiserror-impl dependency-type: indirect update-type: version-update:semver-patch dependency-group: firecracker ... Signed-off-by: dependabot[bot] <[email protected]>
Update release policy ready for release Signed-off-by: Jack Thomson <[email protected]>
Changing the queue size from 256 to 512 increases RX throughput but seems to regress TX throughput by 3% on average. We are not sure what is causing this. Revert this change until we have enough time to investigate and understand better the mechanisms that are in play. Signed-off-by: Babis Chalios <[email protected]>
JackThomson2
requested review from
xmarcalx,
kalyazin,
pb8o and
Manciukic
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## firecracker-v1.10 #4896 +/- ##
==================================================
Coverage 84.10% 84.10%
==================================================
Files 251 251
Lines 28080 28080
==================================================
Hits 23616 23616
Misses 4464 4464
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pb8o
approved these changes
Nov 7, 2024
JackThomson2
added
the
Status: Awaiting review
Manciukic
approved these changes
Nov 7, 2024
JackThomson2
merged commit 97eaf9b
into
firecracker-microvm:firecracker-v1.10
7 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update the release branch with the queue size revert and release policy changes
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.